Convert COMPILE_ASSERT to static_assert

util/file/file_writer.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "util/file/file_writer.h"
 
 #include <algorithm>
 
 #include <limits.h>
 
 #include "base/logging.h"
 #include "base/posix/eintr_wrapper.h"
 #include "util/file/fd_io.h"
 
 namespace crashpad {
 
 // Ensure type compatibility between WritableIoVec and iovec.
-COMPILE_ASSERT(sizeof(WritableIoVec) == sizeof(iovec), WritableIoVec_size);
-COMPILE_ASSERT(offsetof(WritableIoVec, iov_base) == offsetof(iovec, iov_base),
-               WritableIoVec_base_offset);
-COMPILE_ASSERT(offsetof(WritableIoVec, iov_len) == offsetof(iovec, iov_len),
-               WritableIoVec_len_offset);
+static_assert(sizeof(WritableIoVec) == sizeof(iovec), "WritableIoVec size");
+static_assert(offsetof(WritableIoVec, iov_base) == offsetof(iovec, "iov base"),

[Mark Mentovai, 2014/10/01 03:55:12]

You changed the wrong parameter.

../../util/file/file_writer.cc:29:68: error: expected identifier
static_assert(offsetof(WritableIoVec, iov_base) == offsetof(iovec, "iov base"),
                                                                   ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/6.0/include/stddef.h:87:46:
note: expanded from macro 'offsetof'
#define offsetof(t, d) __builtin_offsetof(t, d)

Same on line 31.

[scottmg, 2014/10/01 16:37:18]

Done.

+              WritableIoVec_base_offset);
+static_assert(offsetof(WritableIoVec, iov_len) == offsetof(iovec, "iov len"),
+              WritableIoVec_len_offset);
 
 FileWriter::FileWriter() : fd_() {
 }
 
 FileWriter::~FileWriter() {
 }
 
 bool FileWriter::Open(const base::FilePath& path, int oflag, mode_t mode) {
   CHECK(!fd_.is_valid());
 
@@ skipping 99 matching lines @@
 
   off_t rv = lseek(fd_.get(), offset, whence);
   if (rv < 0) {
     PLOG(ERROR) << "lseek";
   }
 
   return rv;
 }
 
 }  // namespace crashpad