Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 615923003: Chromecast: removes android:permission="INTERNET" from manifest. (Closed)

Created:
6 years, 2 months ago by gunsch
Modified:
6 years, 2 months ago
Reviewers:
lcwu1, byungchul
CC:
chromium-reviews, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast: removes android:permission="INTERNET" from manifest. android:permission puts a restriction on launching the activity such that the launching context must have INTERNET permission. This is not true launching via "am" on non-rooted devices, and makes no sense for the public CastShellApk. R=byungchul@chromium.org BUG=None Committed: https://crrev.com/6c4c7846c0855786a3f4f9dcbc6dcacfd74479cc Cr-Commit-Position: refs/heads/master@{#297462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chromecast/shell/android/apk/AndroidManifest.xml View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
gunsch
6 years, 2 months ago (2014-09-30 15:57:14 UTC) #1
byungchul
Without internet access, what else can cast shell do?
6 years, 2 months ago (2014-09-30 17:22:58 UTC) #2
byungchul
lgtm
6 years, 2 months ago (2014-09-30 17:31:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615923003/1
6 years, 2 months ago (2014-09-30 17:32:54 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-09-30 17:32:56 UTC) #7
lcwu1
lgtm
6 years, 2 months ago (2014-09-30 17:49:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615923003/1
6 years, 2 months ago (2014-09-30 17:50:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as a39a10137a53144b07cb9b3bd310460687929610
6 years, 2 months ago (2014-09-30 18:26:26 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 18:27:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c4c7846c0855786a3f4f9dcbc6dcacfd74479cc
Cr-Commit-Position: refs/heads/master@{#297462}

Powered by Google App Engine
This is Rietveld 408576698