Credential Manager: Stub out call to PasswordStore.

components/password_manager/content/browser/content_credential_manager_dispatcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/content/browser/content_credential_manager_dispatcher.h"
 
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/password_manager/content/common/credential_manager_messages.h"
 #include "components/password_manager/content/common/credential_manager_types.h"
 #include "components/password_manager/core/browser/password_manager_client.h"
+#include "components/password_manager/core/browser/password_store.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "ipc/ipc_message_macros.h"
 
 namespace password_manager {
 
 ContentCredentialManagerDispatcher::ContentCredentialManagerDispatcher(
     content::WebContents* web_contents,
     PasswordManagerClient* client)
     : WebContentsObserver(web_contents),
       client_(client) {

[vabr (Chromium), 2014/09/30 09:38:31]

pending_request_id_(0)

[Mike West, 2014/09/30 09:44:49]

Done.

   DCHECK(web_contents);
 }
 
 ContentCredentialManagerDispatcher::~ContentCredentialManagerDispatcher() {}
 
 bool ContentCredentialManagerDispatcher::OnMessageReceived(
     const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(ContentCredentialManagerDispatcher, message)
     IPC_MESSAGE_HANDLER(CredentialManagerHostMsg_NotifyFailedSignIn,
@@ skipping 28 matching lines @@
 }
 
 void ContentCredentialManagerDispatcher::OnNotifySignedOut(int request_id) {
   // TODO(mkwst): This is a stub.
   web_contents()->GetRenderViewHost()->Send(
       new CredentialManagerMsg_AcknowledgeSignedOut(
           web_contents()->GetRenderViewHost()->GetRoutingID(), request_id));
 }
 
 void ContentCredentialManagerDispatcher::OnRequestCredential(
     int request_id,

[vabr (Chromium), 2014/09/30 09:38:31]

Should you DCHECK(request_id)?

[Mike West, 2014/09/30 09:44:49]

Hrm. That's actually a good question. I don't know whether this is 0-based or
1-based. Let me check that... :)

It's 1-based! Yay!

-    bool zero_click_only,
+    bool /* zero_click_only */,
     const std::vector<GURL>& federations) {
-  // TODO(mkwst): This is a stub.
+  PasswordStore* store = GetPasswordStore();
+  if (pending_request_id_ || !store) {
+    // TODO(mkwst): Reject the promise if we can't get to the password store, or
+    // if we're already requesting credentials.

[vabr (Chromium), 2014/09/30 09:38:32]

Did you want to add a return here?
(Maybe to avoid accessing a NULL store below, but up to you.)

[Mike West, 2014/09/30 09:44:49]

I should have done it here, but I'm now doing it in the next patch. So I'll just
leave this one as-is.

+  }
+
+  pending_request_id_ = request_id;
+
+  autofill::PasswordForm form;
+  form.scheme = autofill::PasswordForm::SCHEME_HTML;
+  form.origin = web_contents()->GetLastCommittedURL().GetOrigin();
+  form.signon_realm = form.origin.spec();
+
+  store->GetLogins(form, PasswordStore::DISALLOW_PROMPT, this);
+}
+
+void ContentCredentialManagerDispatcher::OnGetPasswordStoreResults(
+    const std::vector<autofill::PasswordForm*>& results) {
+  DCHECK(pending_request_id_);
+
+  // TODO(mkwst): This is a stub. We should be looking at |results| here. Baby
+  // steps.
   password_manager::CredentialInfo info(base::ASCIIToUTF16("id"),
                                         base::ASCIIToUTF16("name"),
                                         GURL("https://example.com/image.png"));
   web_contents()->GetRenderViewHost()->Send(
       new CredentialManagerMsg_SendCredential(
           web_contents()->GetRenderViewHost()->GetRoutingID(),
-          request_id,
+          pending_request_id_,
           info));
+  pending_request_id_ = 0;
+}
+
+PasswordStore* ContentCredentialManagerDispatcher::GetPasswordStore() {
+  return client_ ? client_->GetPasswordStore() : nullptr;
 }
 
 }  // namespace password_manager