Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: components/navigation_interception/navigation_params_android.cc

Issue 615853006: Escape url to be used in Java layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/navigation_interception/navigation_params_android.cc
diff --git a/components/navigation_interception/navigation_params_android.cc b/components/navigation_interception/navigation_params_android.cc
index 769450fa9d2816558f67aa50c4dfc6e7dee03ff8..acaddcf62abb76bb9d11d9302980cba34eb3a0fd 100644
--- a/components/navigation_interception/navigation_params_android.cc
+++ b/components/navigation_interception/navigation_params_android.cc
@@ -6,6 +6,7 @@
#include "base/android/jni_string.h"
#include "jni/NavigationParams_jni.h"
+#include "net/base/escape.h"
using base::android::ConvertUTF8ToJavaString;
@@ -14,8 +15,8 @@ namespace navigation_interception {
base::android::ScopedJavaLocalRef<jobject> CreateJavaNavigationParams(
JNIEnv* env,
const NavigationParams& params) {
- ScopedJavaLocalRef<jstring> jstring_url =
- ConvertUTF8ToJavaString(env, params.url().spec());
+ ScopedJavaLocalRef<jstring> jstring_url = ConvertUTF8ToJavaString(
+ env, net::EscapeExternalHandlerValue(params.url().spec()));
Jaekyun Seok (inactive) 2014/10/02 15:31:19 This doesn't seem a proper method for web url esca
Jaekyun Seok (inactive) 2014/10/02 16:30:18 I added my own logic to escape only queries.
return Java_NavigationParams_create(env,
jstring_url.obj(),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698