Handle the keyboard event for ctrl+a inside pdf.js instead of out_of_process_pdf.cc

pdf/out_of_process_instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/out_of_process_instance.h"
 
 #include <algorithm>  // for min/max()
 #define _USE_MATH_DEFINES  // for M_PI
 #include <cmath>      // for log() and pow()
 #include <math.h>
@@ skipping 109 matching lines @@
 // Open the email editor with the given parameters (Plugin -> Page)
 const char kJSEmailType[] = "email";
 const char kJSEmailTo[] = "to";
 const char kJSEmailCc[] = "cc";
 const char kJSEmailBcc[] = "bcc";
 const char kJSEmailSubject[] = "subject";
 const char kJSEmailBody[] = "body";
 // Rotation (Page -> Plugin)
 const char kJSRotateClockwiseType[] = "rotateClockwise";
 const char kJSRotateCounterclockwiseType[] = "rotateCounterclockwise";
+const char kJSSelectAllType[] = "selectAll";

[Nikhil, 2014/10/02 12:27:01]

How about adding a comment here? Looks to be a practice that is being followed
here. Please see comments/code above.

[Deepak, 2014/10/02 12:40:32]

Done.

 
 const int kFindResultCooldownMs = 100;
 
 const double kMinZoom = 0.01;
 
 namespace {
 
 static const char kPPPPdfInterface[] = PPP_PDF_INTERFACE_1;
 
 PP_Var GetLinkAtPosition(PP_Instance instance, PP_Point point) {
@@ skipping 234 matching lines @@
       callback.Run(PP_OK);
     } else {
       NOTREACHED();
     }
   } else if (type == kJSPrintType) {
     Print();
   } else if (type == kJSRotateClockwiseType) {
     RotateClockwise();
   } else if (type == kJSRotateCounterclockwiseType) {
     RotateCounterclockwise();
+  } else if (type == kJSSelectAllType) {
+    engine_->SelectAll();
   } else if (type == kJSResetPrintPreviewModeType &&
              dict.Get(pp::Var(kJSPrintPreviewUrl)).is_string() &&
              dict.Get(pp::Var(kJSPrintPreviewGrayscale)).is_bool() &&
              dict.Get(pp::Var(kJSPrintPreviewPageCount)).is_int()) {
     url_ = dict.Get(pp::Var(kJSPrintPreviewUrl)).AsString();
     preview_pages_info_ = std::queue<PreviewPageInfo>();
     preview_document_load_state_ = LOAD_STATE_COMPLETE;
     document_load_state_ = LOAD_STATE_LOADING;
     LoadUrl(url_);
     preview_engine_.reset();
@@ skipping 84 matching lines @@
           mouse_event.GetClickCount(),
           mouse_event.GetMovement());
       break;
     }
     default:
       break;
   }
   if (engine_->HandleEvent(offset_event))
     return true;
 
   // TODO(raymes): Implement this scroll behavior in JS:

[Nikhil, 2014/10/02 12:27:00]

Is this TODO still valid?

[Deepak, 2014/10/02 12:40:32]

I think this is handles in the js by arrow keys and page up down, As comments
was already their, raymus , please tell us your opinion.

   // When click+dragging, scroll the document correctly.
 
-  if (event.GetType() == PP_INPUTEVENT_TYPE_KEYDOWN &&
-      event.GetModifiers() & kDefaultKeyModifier) {
-    pp::KeyboardInputEvent keyboard_event(event);
-    switch (keyboard_event.GetKeyCode()) {
-      case 'A':
-        engine_->SelectAll();
-        return true;
-    }
-  }
-
   // Return true for unhandled clicks so the plugin takes focus.
   return (event.GetType() == PP_INPUTEVENT_TYPE_MOUSEDOWN);
 }
 
 void OutOfProcessInstance::DidChangeView(const pp::View& view) {
   pp::Rect view_rect(view.GetRect());
   float old_device_scale = device_scale_;
   float device_scale = view.GetDeviceScale();
   pp::Size view_device_size(view_rect.width() * device_scale,
                             view_rect.height() * device_scale);
@@ skipping 855 matching lines @@
 pp::Point OutOfProcessInstance::BoundScrollOffsetToDocument(
     const pp::Point& scroll_offset) {
   int max_x = document_size_.width() * zoom_ - plugin_dip_size_.width();
   int x = std::max(std::min(scroll_offset.x(), max_x), 0);
   int max_y = document_size_.height() * zoom_ - plugin_dip_size_.height();
   int y = std::max(std::min(scroll_offset.y(), max_y), 0);
   return pp::Point(x, y);
 }
 
 }  // namespace chrome_pdf