Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 615843004: Make hasCookieStoreLoaded visible for testing (Closed)

Created:
6 years, 2 months ago by Yusuf
Modified:
6 years, 2 months ago
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, jkarlin+watch_chromium.org, davidben+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make hasCookieStoreLoaded visible for testing We need to start using this method for testing purposes downstream but without the annotations it is getting stripped our by proguard. BUG=372774 Committed: https://crrev.com/67d86f63228f12ecd59762ef44c190c51a37823d Cr-Commit-Position: refs/heads/master@{#297867}

Patch Set 1 #

Patch Set 2 : Removed a thread.sleep while loop #

Total comments: 1

Patch Set 3 : Added a lot of javadoc #

Patch Set 4 : Added missing exception #

Patch Set 5 : Switched to using another threadUtils API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandler.java View 1 2 3 chunks +29 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java View 1 2 3 4 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Yusuf
6 years, 2 months ago (2014-10-01 21:02:58 UTC) #2
David Trainor- moved to gerrit
lgtm https://chromiumcodereview.appspot.com/615843004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandler.java File chrome/android/java/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandler.java (right): https://chromiumcodereview.appspot.com/615843004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandler.java#newcode43 chrome/android/java/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandler.java:43: public static boolean checkCookieStoreLoadedForTesting(Profile profile) { javadoc
6 years, 2 months ago (2014-10-01 23:15:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615843004/40001
6 years, 2 months ago (2014-10-01 23:29:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/9181) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/14451)
6 years, 2 months ago (2014-10-01 23:54:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615843004/60001
6 years, 2 months ago (2014-10-02 17:32:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615843004/80001
6 years, 2 months ago (2014-10-02 17:57:31 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 5ee2fe78103f8180d73a881a565d07cc19f1a791
6 years, 2 months ago (2014-10-02 18:28:53 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 18:29:33 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/67d86f63228f12ecd59762ef44c190c51a37823d
Cr-Commit-Position: refs/heads/master@{#297867}

Powered by Google App Engine
This is Rietveld 408576698