Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 615823002: Temporarily remove didReceiveDataForMainResource() implementation (Closed)

Created:
6 years, 2 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, michaeln, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Temporarily remove didReceiveDataForMainResource() implementation The method signature of blink::WebApplicationCacheHost::didReceiveDataForMainResource() is going to be changed. Not to break build, need to remove the implementation of the interface in Chromium. Blink side CL is here: https://codereview.chromium.org/618583002/ R=mkwst,jam BUG=418885 Committed: https://crrev.com/715a73be0dfef058b5d131189cb0a205ce2fb027 Cr-Commit-Position: refs/heads/master@{#297780}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Addressed #4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M content/child/appcache/web_application_cache_host_impl.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/child/appcache/web_application_cache_host_impl.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
tyoshino (SeeGerritForStatus)
Hi jam. Please take a look. "overload" annotation checker prevents me from duplicating the methods ...
6 years, 2 months ago (2014-10-01 03:47:21 UTC) #2
Mike West
Rather than commenting them out, please just delete the code. You can always revert later.
6 years, 2 months ago (2014-10-01 08:53:15 UTC) #4
tyoshino (SeeGerritForStatus)
On 2014/10/01 08:53:15, Mike West wrote: > Rather than commenting them out, please just delete ...
6 years, 2 months ago (2014-10-01 08:58:37 UTC) #5
Mike West
LGTM, but you'll need a content/ OWNER to stamp the change. Perhaps Jochen has a ...
6 years, 2 months ago (2014-10-01 09:06:58 UTC) #7
Mike West
(Also, would you mind updating the change description to explain what you're doing here? "Correct ...
6 years, 2 months ago (2014-10-01 09:07:53 UTC) #8
jam
lgtm
6 years, 2 months ago (2014-10-01 22:09:22 UTC) #9
tyoshino (SeeGerritForStatus)
On 2014/10/01 09:07:53, Mike West wrote: > (Also, would you mind updating the change description ...
6 years, 2 months ago (2014-10-02 03:22:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615823002/50001
6 years, 2 months ago (2014-10-02 03:23:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615823002/50001
6 years, 2 months ago (2014-10-02 03:44:51 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:50001) as 25d1763c243b16bb86258c287910f8cbfd18b4d8
6 years, 2 months ago (2014-10-02 04:16:18 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 04:16:55 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/715a73be0dfef058b5d131189cb0a205ce2fb027
Cr-Commit-Position: refs/heads/master@{#297780}

Powered by Google App Engine
This is Rietveld 408576698