Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: src/preparser.cc

Issue 615813004: Allow escape sequences in Constructor/Prototype tokens in PreParserTraits::GetSymbol() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/scanner.h » ('j') | src/scanner.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/preparser.cc
diff --git a/src/preparser.cc b/src/preparser.cc
index 3173cc0f900255aa1d764736d8c6f70d51da0ddb..44ef2ab9b8d367f75ecf12c7407b9b4b23d04747 100644
--- a/src/preparser.cc
+++ b/src/preparser.cc
@@ -72,16 +72,16 @@ PreParserIdentifier PreParserTraits::GetSymbol(Scanner* scanner) {
} else if (scanner->current_token() == Token::YIELD) {
return PreParserIdentifier::Yield();
}
- if (scanner->UnescapedLiteralMatches("eval", 4)) {
+ if (scanner->LiteralMatches("eval", 4)) {
caitp (gmail) 2014/10/01 20:52:18 I'm not sure if this should be used for "eval" and
arv (Not doing code reviews) 2014/10/01 21:00:34 eval and arguments should be the unescaped one.
return PreParserIdentifier::Eval();
}
- if (scanner->UnescapedLiteralMatches("arguments", 9)) {
+ if (scanner->LiteralMatches("arguments", 9)) {
return PreParserIdentifier::Arguments();
}
- if (scanner->UnescapedLiteralMatches("prototype", 9)) {
+ if (scanner->LiteralMatches("prototype", 9)) {
return PreParserIdentifier::Prototype();
}
- if (scanner->UnescapedLiteralMatches("constructor", 11)) {
+ if (scanner->LiteralMatches("constructor", 11)) {
return PreParserIdentifier::Constructor();
}
return PreParserIdentifier::Default();
« no previous file with comments | « no previous file | src/scanner.h » ('j') | src/scanner.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698