Allow escape sequences in Constructor/Prototype tokens in PreParserTraits::GetSymbol()

src/scanner.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Features shared by parsing and pre-parsing scanners.
 
 #ifndef V8_SCANNER_H_
 #define V8_SCANNER_H_
 
 #include "src/allocation.h"
@@ skipping 376 matching lines @@
   bool UnescapedLiteralMatches(const char* data, int length) {
     if (is_literal_one_byte() &&
         literal_length() == length &&
         !literal_contains_escapes()) {
       const char* token =
           reinterpret_cast<const char*>(literal_one_byte_string().start());
       return !strncmp(token, data, length);
     }
     return false;
   }
+
+  bool LiteralMatches(const char* data, int length) {
+    if (current_token() == Token::STRING &&

[caitp (gmail), 2014/10/01 20:52:18]

The check for Token::STRING is simply because I don't fully understand the
scanner yet, it was a really quick look to see how this could work. It may not
be necessary.

+        is_literal_one_byte() &&
+        literal_length() == length) {
+      const char* token =
+          reinterpret_cast<const char*>(literal_one_byte_string().start());
+      return !strncmp(token, data, length);
+    }
+    return UnescapedLiteralMatches(data, length);

[caitp (gmail), 2014/10/01 20:52:18]

But if it does turn out to be necessary, I want to use the
unescapedliteralmatches to verify non-string-literals.

[arv (Not doing code reviews), 2014/10/01 21:00:35]

Is the only difference here is the literal_contains_escapes? If so, maybe
refactor to share the code?

+  }
+
   void IsGetOrSet(bool* is_get, bool* is_set) {
     if (is_literal_one_byte() &&
         literal_length() == 3 &&
         !literal_contains_escapes()) {
       const char* token =
           reinterpret_cast<const char*>(literal_one_byte_string().start());
       *is_get = strncmp(token, "get", 3) == 0;
       *is_set = !*is_get && strncmp(token, "set", 3) == 0;
     }
   }
@@ skipping 246 matching lines @@
   bool harmony_modules_;
   // Whether we scan 0o777 and 0b111 as numbers.
   bool harmony_numeric_literals_;
   // Whether we scan 'class', 'extends', 'static' and 'super' as keywords.
   bool harmony_classes_;
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_SCANNER_H_