Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1331)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 615803002: Fix typo in host_installer.js (Closed)

Created:
6 years, 2 months ago by Sergey Ulanov
Modified:
6 years, 2 months ago
Reviewers:
Jamie, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix typo in host_installer.js BUG=418859 Committed: https://crrev.com/dbcbacdda074a8281df82fb547c6e2453a61e55b Cr-Commit-Position: refs/heads/master@{#297470}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M remoting/webapp/host_installer.js View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Sergey Ulanov
6 years, 2 months ago (2014-09-30 04:53:26 UTC) #2
Jamie
lgtm https://codereview.chromium.org/615803002/diff/1/remoting/webapp/host_installer.js File remoting/webapp/host_installer.js (right): https://codereview.chromium.org/615803002/diff/1/remoting/webapp/host_installer.js#newcode131 remoting/webapp/host_installer.js:131: if (that.downloadAndWaitForInstallPromise_ == null) { ===, for consistency ...
6 years, 2 months ago (2014-09-30 17:05:47 UTC) #3
kelvinp
lgtm
6 years, 2 months ago (2014-09-30 17:44:16 UTC) #4
Sergey Ulanov
https://codereview.chromium.org/615803002/diff/1/remoting/webapp/host_installer.js File remoting/webapp/host_installer.js (right): https://codereview.chromium.org/615803002/diff/1/remoting/webapp/host_installer.js#newcode131 remoting/webapp/host_installer.js:131: if (that.downloadAndWaitForInstallPromise_ == null) { On 2014/09/30 17:05:47, Jamie ...
6 years, 2 months ago (2014-09-30 17:57:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615803002/20001
6 years, 2 months ago (2014-09-30 18:00:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as dc0e7141fd67674071880fd58cbc443df265f2df
6 years, 2 months ago (2014-09-30 18:59:16 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 19:00:33 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/dbcbacdda074a8281df82fb547c6e2453a61e55b
Cr-Commit-Position: refs/heads/master@{#297470}

Powered by Google App Engine
This is Rietveld 408576698