closure: add bash script to build and run Java tests from command line.

closure: add bash script to build and run Java tests from command line.

R=vitalyp@chromium.org,tbreisacher@chromium.org
BUG=393873
Committed: https://crrev.com/dd79158782326a3ee31ec772c3c8a8bba81d53ff
Cr-Commit-Position: refs/heads/master@{#297440}

[Dan Beam, 2014-09-30 01:46:17]

dbeam@chromium.org changed reviewers:
+ vitalyp@chromium.org

[Vitaly Pavlenko, 2014-09-30 02:42:20]

lgtm

https://codereview.chromium.org/615733002/diff/1/third_party/closure_compiler...
File third_party/closure_compiler/build_and_run_tests (right):

https://codereview.chromium.org/615733002/diff/1/third_party/closure_compiler...
third_party/closure_compiler/build_and_run_tests:28: readonly
cp=".:./runner/test:./runner/src:\
I would probably s/cp/classpath/ to not confuse reader to think "why these guys
are redefining my Bash cp utility?"

https://codereview.chromium.org/615733002/diff/1/third_party/closure_compiler...
third_party/closure_compiler/build_and_run_tests:36: javac -cp "$cp"
runner/test/com/google/javascript/jscomp/ChromePassTest.java
prefer "${var}" over "$var"

https://google-styleguide.googlecode.com/svn/trunk/shell.xml?showone=Variable...

https://codereview.chromium.org/615733002/diff/1/third_party/closure_compiler...
third_party/closure_compiler/build_and_run_tests:38: echo "Running tests"
Should be done only after successfully compilation on previous step.

[Dan Beam, 2014-09-30 03:08:38]

https://codereview.chromium.org/615733002/diff/1/third_party/closure_compiler...
File third_party/closure_compiler/build_and_run_tests (right):

https://codereview.chromium.org/615733002/diff/1/third_party/closure_compiler...
third_party/closure_compiler/build_and_run_tests:28: readonly
cp=".:./runner/test:./runner/src:\
On 2014/09/30 02:42:20, Vitaly Pavlenko wrote:
> I would probably s/cp/classpath/ to not confuse reader to think "why these
guys
> are redefining my Bash cp utility?"

Done.

https://codereview.chromium.org/615733002/diff/1/third_party/closure_compiler...
third_party/closure_compiler/build_and_run_tests:36: javac -cp "$cp"
runner/test/com/google/javascript/jscomp/ChromePassTest.java
On 2014/09/30 02:42:20, Vitaly Pavlenko wrote:
> prefer "${var}" over "$var"
> 
>
https://google-styleguide.googlecode.com/svn/trunk/shell.xml?showone=Variable...

Done.

https://codereview.chromium.org/615733002/diff/1/third_party/closure_compiler...
third_party/closure_compiler/build_and_run_tests:38: echo "Running tests"
On 2014/09/30 02:42:20, Vitaly Pavlenko wrote:
> Should be done only after successfully compilation on previous step.

Done.

[Tyler Breisacher (Chromium), 2014-09-30 15:16:11]

lgtm

[Dan Beam, 2014-09-30 16:39:51]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-09-30 16:40:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/615733002/40001

[commit-bot: I haz the power, 2014-09-30 17:17:22]

Committed patchset #3 (id:40001) as d61ecdd7c584920c68406c63e17b69f350be444c

[commit-bot: I haz the power, 2014-09-30 17:18:02]

Patchset 3 (id:??) landed as
https://crrev.com/dd79158782326a3ee31ec772c3c8a8bba81d53ff
Cr-Commit-Position: refs/heads/master@{#297440}

[Vitaly Pavlenko, 2014-10-01 00:04:59]

https://chromiumcodereview.appspot.com/615733002/diff/40001/third_party/closu...
File third_party/closure_compiler/build_and_run_tests (right):

https://chromiumcodereview.appspot.com/615733002/diff/40001/third_party/closu...
third_party/closure_compiler/build_and_run_tests:47: echo "Cleaning up"
Actually, this "echo" is better to pull inside cleanup(). So when user is
pressing Ctrl+C, he could see that the script cleans up after itself.