Issue 61573002: Docserver: Disable escaping of enum value descriptions and fix some scope leakage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 61573002: Docserver: Disable escaping of enum value descriptions and fix some scope leakage. (Closed)

Created:
7 years, 1 month ago by Sam McNally

Modified:
7 years, 1 month ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Docserver: Disable escaping of enum value descriptions and fix some scope leakage. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233315

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -7 lines)			Patch
M	chrome/common/extensions/docs/server2/app.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/server2/cron.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/templates/private/enum_descriptions.html	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/docs/templates/private/type.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/templates/private/variable_type.html	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

not at google - send to devlin

lgtm I'm just going to submit this for you now so I don't have to ...

7 years, 1 month ago (2013-11-06 18:43:38 UTC) #2

not at google - send to devlin

lgtm lgtm I'm just going to submit this for you now so I don't have ...

7 years, 1 month ago (2013-11-06 18:43:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/61573002/1

7 years, 1 month ago (2013-11-06 18:51:55 UTC) #4

Message was sent while issue was closed.

Change committed as 233315