Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 615693002: Improve MessageLoop's comments. (Closed)

Created:
6 years, 2 months ago by maniscalco
Modified:
6 years, 2 months ago
Reviewers:
Mark Mentovai, akalin
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Improve MessageLoop's comments. Remove incorrect mention of RefCountedThreadSafe from DeleteSoon's comment. Replace mention of PostDelayedTask with ReleaseSoon in ReleaseSoon's comment. BUG= Committed: https://crrev.com/9be04f02356b1bb6ebeb8048e4d6449f5d3f8bee Cr-Commit-Position: refs/heads/master@{#297870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M base/message_loop/message_loop.h View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
maniscalco
Hi Mark, would you please review this comment only change? Please double check me on ...
6 years, 2 months ago (2014-09-29 21:26:26 UTC) #2
Mark Mentovai
→akalin
6 years, 2 months ago (2014-09-29 21:49:57 UTC) #4
maniscalco
On 2014/09/29 21:49:57, Mark Mentovai wrote: > →akalin Mark, I don't think akalin works on ...
6 years, 2 months ago (2014-10-02 17:40:09 UTC) #5
Mark Mentovai
You’re right, looks like he’s gone. He had introduced or modified these interfaces, so I ...
6 years, 2 months ago (2014-10-02 17:46:12 UTC) #6
maniscalco
On 2014/10/02 17:46:12, Mark Mentovai wrote: > You’re right, looks like he’s gone. He had ...
6 years, 2 months ago (2014-10-02 17:50:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615693002/1
6 years, 2 months ago (2014-10-02 17:52:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1b52298e81c01a999f5fdd1c0e5ab3f46cd2aba2
6 years, 2 months ago (2014-10-02 18:35:41 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 18:37:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9be04f02356b1bb6ebeb8048e4d6449f5d3f8bee
Cr-Commit-Position: refs/heads/master@{#297870}

Powered by Google App Engine
This is Rietveld 408576698