Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1392)

Issue 615663003: Remove unused StyleChangeReason::Plugin. (Closed)

Created:
6 years, 2 months ago by rune
Modified:
6 years, 2 months ago
Reviewers:
pdr., kouhei (in TOK)
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove unused StyleChangeReason::Plugin. The "reason" was used when setNeedsStyleRecalc was used to trigger a re-attachment of plugin renderers. After landing https://codereview.chromium.org/596773002 a lazy re-attach is done instead and this constant is no longer in use. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182879

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/core/dom/StyleChangeReason.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/StyleChangeReason.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
rune
6 years, 2 months ago (2014-09-29 22:35:39 UTC) #2
kouhei (in TOK)
lgtm
6 years, 2 months ago (2014-09-29 22:59:06 UTC) #3
pdr.
On 2014/09/29 22:59:06, kouhei wrote: > lgtm LGTM2
6 years, 2 months ago (2014-09-30 00:58:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615663003/1
6 years, 2 months ago (2014-09-30 00:59:25 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 02:10:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182879

Powered by Google App Engine
This is Rietveld 408576698