content/browser/frame_host/render_frame_host_impl.cc - Issue 615633005: PlzNavigate: Move the navigation logic to NavigatorImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 615633005: PlzNavigate: Move the navigation logic to NavigatorImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@commit-nav

Patch Set: Addressed comments + moved unittests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigator_impl_unittest.cc ('K') | « content/browser/frame_host/navigator_impl_unittest.cc ('k') | content/browser/frame_host/render_frame_host_manager.h » ('j') | content/browser/frame_host/render_frame_host_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index bf8ce2b3eeb1be58f253124870d4a2f7e376aba9..40d449bece0d087db89954de850e1f7e578f3e9f 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -1056,7 +1056,8 @@ void RenderFrameHostImpl::OnBeginNavigation(

const CommonNavigationParams& common_params) {

CHECK(CommandLine::ForCurrentProcess()->HasSwitch(

switches::kEnableBrowserSideNavigation));

- frame_tree_node()->render_manager()->OnBeginNavigation(params, common_params);

+ frame_tree_node()->navigator()->OnBeginNavigation(

+ frame_tree_node(), params, common_params);

}

void RenderFrameHostImpl::OnAccessibilityEvents(