Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 615623002: Porting more tests to app_shell_browsertests. (Closed)

Created:
6 years, 2 months ago by lfg
Modified:
6 years, 2 months ago
Reviewers:
Fady Samuel, Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Porting more tests to app_shell_browsertests. The tests included in this CL are: TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged TestFindAPI TestFindAPI_findupdate TestGetProcessId TestHiddenBeforeNavigation TestInlineScriptFromAccessibleResources TestInvalidChromeExtensionURL BUG=352293 Committed: https://crrev.com/ca73bb0e2d9f84c5dbcb738d1fca0e34269651f2 Cr-Commit-Position: refs/heads/master@{#297537}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, --2 lines) Patch
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download
A + extensions/test/data/web_view/apitest/guest_with_inline_script.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/web_view/apitest/inject_hidden_test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/test/data/web_view/apitest/main.js View 1 2 3 2 chunks +250 lines, -0 lines 0 comments Download
M extensions/test/data/web_view/apitest/manifest.json View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
lfg
6 years, 2 months ago (2014-09-29 19:36:13 UTC) #2
Fady Samuel
Yaay! LGTM
6 years, 2 months ago (2014-09-30 18:03:04 UTC) #3
Fady Samuel
Yaay! LGTM
6 years, 2 months ago (2014-09-30 18:03:08 UTC) #4
lfg
yoz@chromium.org: Please review changes in extensions/*
6 years, 2 months ago (2014-09-30 18:07:20 UTC) #6
Yoyo Zhou
LGTM
6 years, 2 months ago (2014-09-30 20:26:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615623002/60001
6 years, 2 months ago (2014-09-30 21:14:22 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001) as a9c779cfebc460ec38a60091e13d499ea6061bba
6 years, 2 months ago (2014-09-30 23:16:29 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 23:17:17 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ca73bb0e2d9f84c5dbcb738d1fca0e34269651f2
Cr-Commit-Position: refs/heads/master@{#297537}

Powered by Google App Engine
This is Rietveld 408576698