Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 615613002: Enabled detection of different refresh rates per monitor on Windows (Closed)

Created:
6 years, 2 months ago by bajones
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enabled detection of different refresh rates per monitor on Windows BUG=418684 Committed: https://crrev.com/47bcf86d02eea44e340acd1bdb1ca2a9b1c3942f Cr-Commit-Position: refs/heads/master@{#297277}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing jbauman's nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -26 lines) Patch
M ui/gl/gl_surface_win.cc View 1 2 chunks +70 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
bajones
6 years, 2 months ago (2014-09-29 18:46:30 UTC) #2
jbauman
lgtm with a couple of nits. https://codereview.chromium.org/615613002/diff/1/ui/gl/gl_surface_win.cc File ui/gl/gl_surface_win.cc (right): https://codereview.chromium.org/615613002/diff/1/ui/gl/gl_surface_win.cc#newcode119 ui/gl/gl_surface_win.cc:119: if (result != ...
6 years, 2 months ago (2014-09-29 19:37:07 UTC) #3
bajones
Thanks for the feedback, addressed both of those. kbr@: Can I get an owner's LGTM?
6 years, 2 months ago (2014-09-29 20:17:42 UTC) #4
Ken Russell (switch to Gerrit)
lgtm
6 years, 2 months ago (2014-09-29 20:33:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615613002/20001
6 years, 2 months ago (2014-09-29 20:39:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 2e59fb4a4017ff558d45e663c86d955e9530c186
6 years, 2 months ago (2014-09-29 21:48:14 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 21:51:37 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47bcf86d02eea44e340acd1bdb1ca2a9b1c3942f
Cr-Commit-Position: refs/heads/master@{#297277}

Powered by Google App Engine
This is Rietveld 408576698