Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 615593002: Remove unused functions WTFSetCrashHook, WTFInstallReportBacktraceOnCrashHook and WTFInvokeCrashHoo… (Closed)

Created:
6 years, 2 months ago by arunprasadr
Modified:
6 years, 2 months ago
CC:
aandrey+blink_chromium.org, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove unused functions WTFSetCrashHook, WTFInstallReportBacktraceOnCrashHook and WTFInvokeCrashHook. WTFSetCrashHook, WTFInstallReportBacktraceOnCrashHook functions are not called from anywhere, Actually these functions were only used during old WebKit days by other WebKit ports. Now it is no longer useful for Blink, hence removing. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -59 lines) Patch
M Source/wtf/Assertions.h View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/wtf/Assertions.cpp View 2 chunks +0 lines, -53 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
arunprasadr
PTAL
6 years, 2 months ago (2014-09-29 17:59:46 UTC) #2
Mike West
Hrm. mac_blink_rel is failing. Throwing this at a few more bots to see what they ...
6 years, 2 months ago (2014-09-29 18:44:06 UTC) #4
arunprasadr
On 2014/09/29 18:44:06, Mike West wrote: > Hrm. mac_blink_rel is failing. Throwing this at a ...
6 years, 2 months ago (2014-09-30 03:45:43 UTC) #5
Mike West
Hrm. The debug bot passed. *shrug* LGTM if the CQ lets you land it, but ...
6 years, 2 months ago (2014-09-30 06:23:00 UTC) #6
arunprasadr
Thanks @mike. @morrita, @jochen PTAL.
6 years, 2 months ago (2014-09-30 06:30:09 UTC) #8
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-09-30 08:43:20 UTC) #9
arunprasadr
On 2014/09/30 08:43:20, jochen (slow for reviews) wrote: > lgtm Thanks @jochen.
6 years, 2 months ago (2014-09-30 10:21:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615593002/1
6 years, 2 months ago (2014-09-30 10:21:41 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink ()
6 years, 2 months ago (2014-09-30 11:31:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615593002/1
6 years, 2 months ago (2014-10-07 07:11:40 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink ()
6 years, 2 months ago (2014-10-07 09:10:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615593002/1
6 years, 2 months ago (2014-10-14 12:54:07 UTC) #20
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 12:54:57 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183667

Powered by Google App Engine
This is Rietveld 408576698