Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 615573003: Convert layer-related tests in fast/multicol to ref-tests. (Closed)

Created:
6 years, 2 months ago by andersr
Modified:
6 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Convert layer-related tests in fast/multicol to ref-tests. layers-split-across-columns: * Use standards mode, not quirks mode. * Remove unnecessary uses of inline-block. (Abs. position instead). * Make things smaller, such that the entire test actually fits in the standard content_shell dimensions. layers-in-multicol: * Standards mode. * Rewrote test to fit in content_shell. Finally, removed related useless test-cases in fast/multicol/newmulticol. R=mstensho@opera.com BUG=380217 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183198

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix DOCTYPE. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -2318 lines) Patch
M LayoutTests/TestExpectations View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/layers-in-multicol.html View 1 1 chunk +66 lines, -131 lines 0 comments Download
A LayoutTests/fast/multicol/layers-in-multicol-expected.html View 1 1 chunk +81 lines, -0 lines 0 comments Download
M LayoutTests/fast/multicol/layers-split-across-columns.html View 1 1 chunk +22 lines, -22 lines 0 comments Download
A LayoutTests/fast/multicol/layers-split-across-columns-expected.html View 1 1 chunk +87 lines, -0 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/layers-in-multicol.html View 1 chunk +0 lines, -135 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/layers-in-multicol-expected.html View 1 chunk +0 lines, -133 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/layers-split-across-columns.html View 1 chunk +0 lines, -69 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/layers-split-across-columns-expected.html View 1 chunk +0 lines, -69 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/layers-in-multicol-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/layers-in-multicol-expected.txt View 1 chunk +0 lines, -355 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/layers-split-across-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/layers-split-across-columns-expected.txt View 1 chunk +0 lines, -84 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/layers-in-multicol-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/layers-in-multicol-expected.txt View 1 2 1 chunk +0 lines, -355 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/layers-split-across-columns-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/layers-split-across-columns-expected.txt View 1 2 1 chunk +0 lines, -84 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/layers-in-multicol-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/layers-in-multicol-expected.txt View 1 chunk +0 lines, -355 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/layers-split-across-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/layers-split-across-columns-expected.txt View 1 chunk +0 lines, -84 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/layers-in-multicol-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/layers-in-multicol-expected.txt View 1 chunk +0 lines, -355 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/layers-split-across-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/layers-split-across-columns-expected.txt View 1 chunk +0 lines, -84 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
andersr
6 years, 2 months ago (2014-10-03 12:08:11 UTC) #2
rune
LGTM https://codereview.chromium.org/615573003/diff/1/LayoutTests/fast/multicol/layers-in-multicol.html File LayoutTests/fast/multicol/layers-in-multicol.html (right): https://codereview.chromium.org/615573003/diff/1/LayoutTests/fast/multicol/layers-in-multicol.html#newcode1 LayoutTests/fast/multicol/layers-in-multicol.html:1: <!doctype html> minor nit: we normally up-case <!DOCTYPE ...
6 years, 2 months ago (2014-10-03 12:48:14 UTC) #3
andersr
> minor nit: we normally up-case <!DOCTYPE html>. Done.
6 years, 2 months ago (2014-10-03 13:03:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615573003/20001
6 years, 2 months ago (2014-10-03 13:03:52 UTC) #6
commit-bot: I haz the power
Failed to apply patch for LayoutTests/platform/mac-lion/fast/multicol/layers-in-multicol-expected.png: While running svn delete LayoutTests/platform/mac-lion/fast/multicol/layers-in-multicol-expected.png --force --config-dir /b/infra_internal/commit_queue/subversion_config --non-interactive; ...
6 years, 2 months ago (2014-10-03 13:04:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615573003/40001
6 years, 2 months ago (2014-10-03 13:38:16 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 15:46:19 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 183198

Powered by Google App Engine
This is Rietveld 408576698