Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 615563003: [chromedriver] Fix git migration issue and remove svn support from run_buildbot_steps.py (Closed)

Created:
6 years, 2 months ago by samuong
Modified:
6 years, 2 months ago
Reviewers:
stgao
CC:
chromium-reviews, stgao, klundberg, jbudorick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Fix git migration issue and remove svn support from run_buildbot_steps.py BUG=418590 NOTRY=true Committed: https://crrev.com/e84ed4a93cda4308c3f063ecc569eb514e6d9478 Cr-Commit-Position: refs/heads/master@{#297453}

Patch Set 1 #

Patch Set 2 : Replace "SVN revision" with "commit position" in comments and output #

Total comments: 4

Patch Set 3 : Change "revision" to "commit_position" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -48 lines) Patch
M chrome/test/chromedriver/run_buildbot_steps.py View 1 2 10 chunks +44 lines, -48 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
samuong
6 years, 2 months ago (2014-09-30 02:55:42 UTC) #2
stgao
lgtm with nits https://codereview.chromium.org/615563003/diff/20001/chrome/test/chromedriver/run_buildbot_steps.py File chrome/test/chromedriver/run_buildbot_steps.py (right): https://codereview.chromium.org/615563003/diff/20001/chrome/test/chromedriver/run_buildbot_steps.py#newcode125 chrome/test/chromedriver/run_buildbot_steps.py:125: def _UpdateTestResultsLog(platform, revision, passed): |revision| -> ...
6 years, 2 months ago (2014-09-30 17:47:11 UTC) #3
stgao
You could do NOTRY=true for this CL.
6 years, 2 months ago (2014-09-30 17:58:42 UTC) #4
samuong
https://codereview.chromium.org/615563003/diff/20001/chrome/test/chromedriver/run_buildbot_steps.py File chrome/test/chromedriver/run_buildbot_steps.py (right): https://codereview.chromium.org/615563003/diff/20001/chrome/test/chromedriver/run_buildbot_steps.py#newcode125 chrome/test/chromedriver/run_buildbot_steps.py:125: def _UpdateTestResultsLog(platform, revision, passed): On 2014/09/30 17:47:11, Shuotao wrote: ...
6 years, 2 months ago (2014-09-30 18:07:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615563003/40001
6 years, 2 months ago (2014-09-30 18:10:30 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as e8937ea6da5a80a955bae00335d5e4a3390ec570
6 years, 2 months ago (2014-09-30 18:12:11 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 18:13:43 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e84ed4a93cda4308c3f063ecc569eb514e6d9478
Cr-Commit-Position: refs/heads/master@{#297453}

Powered by Google App Engine
This is Rietveld 408576698