Fix use-after-free in BrowserActionView::~BrowserActionView()

Fix use-after-free in BrowserActionView::~BrowserActionView()

BrowserActionView::~BrowserActionView deletes ExtensionActionViewController,
which calls CleanupPopup, which resets a MenuButton::PressedLock, which was
already deleted. Fix the order of destruction.

BUG=418737
Committed: https://crrev.com/5b2368cfdf6e0790910eb7c0be5fdb0d068e00a3
Cr-Commit-Position: refs/heads/master@{#297325}

[Devlin, 2014-09-29 23:07:15]

rdevlin.cronin@chromium.org changed reviewers:
+ sky@chromium.org

[Devlin, 2014-09-29 23:07:15]

Scott, PTAL.  Could also fix this easily by reset()ing |pressed_lock_| in
~BrowserActionView(), if you prefer.

[sky, 2014-09-29 23:49:39]

LGTM

[Devlin, 2014-09-30 00:02:51]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-09-30 00:03:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/615543006/1

[commit-bot: I haz the power, 2014-09-30 01:10:30]

Committed patchset #1 (id:1) as b9467412e0c9544579835e5f0db9b60cc79b1945

[commit-bot: I haz the power, 2014-09-30 01:12:19]

Patchset 1 (id:??) landed as
https://crrev.com/5b2368cfdf6e0790910eb7c0be5fdb0d068e00a3
Cr-Commit-Position: refs/heads/master@{#297325}