Issue 615533002: Fix DevToolsManagerTest.TestObserver flakiness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 615533002: Fix DevToolsManagerTest.TestObserver flakiness. (Closed)

Created:
6 years, 2 months ago by dgozman

Modified:
6 years, 2 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix DevToolsManagerTest.TestObserver flakiness. BUG=418258 TBR=pfeldman Committed: https://crrev.com/3e783e26d6652fcfbe3da2da1e4ce7d4784274fb Cr-Commit-Position: refs/heads/master@{#297174}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -38 lines)			Patch
M	content/browser/devtools/devtools_manager.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/devtools/devtools_manager.cc	View	3 chunks	+16 lines, -12 lines	0 comments	Download
M	content/browser/devtools/devtools_manager_unittest.cc	View	5 chunks	+42 lines, -23 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615533002/1

6 years, 2 months ago (2014-09-29 13:02:22 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as 026cbf8c94dce2bd85fcb5670557c33f54468f7c

6 years, 2 months ago (2014-09-29 15:04:38 UTC) #3

commit-bot: I haz the power

6 years, 2 months ago (2014-09-29 15:05:46 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3e783e26d6652fcfbe3da2da1e4ce7d4784274fb
Cr-Commit-Position: refs/heads/master@{#297174}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages