Issue 61553004: DevTools: fix DevTools Window lifetime with fast_unload_controller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 61553004: DevTools: fix DevTools Window lifetime with fast_unload_controller (Closed)

Created:
7 years, 1 month ago by lushnikov

Modified:
7 years, 1 month ago

Reviewers:
vsevik, pfeldman

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

DevTools: fix DevTools Window lifetime with fast_unload_controller In case of undocked DevTools, we rely on NOTIFICATION_TAB_CLOSING to figure out the moment to destroy DevTools window. However, fast_unload_controller detaches WebContents from browser after receivign beforeunload ack, so we'll never destroy associated DevTools window. This patch triggers DevTools window destruction in result of WebContentsDestroyed callback on front_end WebContents. BUG=315502 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233269

Patch Set 1 #

Patch Set 2 : call UpdateBrowserToolbar in DevToolsWindow destructor unconditionally #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -21 lines)			Patch
	M	chrome/browser/devtools/devtools_window.cc	View	1	6 chunks	+14 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

lushnikov

There's a test case in https://codereview.chromium.org/23835007/ that covers this with the --enable-fast-unload flag. I may ...

7 years, 1 month ago (2013-11-06 10:23:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/61553004/50001

7 years, 1 month ago (2013-11-06 12:27:40 UTC) #3

lushnikov

7 years, 1 month ago (2013-11-06 14:33:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r233269 (presubmit successful).

Expand Messages | Collapse Messages