Remove TextureImageTransportSurface

Remove TextureImageTransportSurface

There is a lot of unreached image transport code due to
- TextureImageTransportSurface actually being unused
as a transport surface now (we either use delegated rendering
or composite-to-mailbox)
- Mac using delegated rendering

TBR=sky@chromium.org

Committed: https://crrev.com/ef40ec9021eea9fe5122c155ff5480affa41a577
Cr-Commit-Position: refs/heads/master@{#297490}

[no sievers, 2014-09-29 23:05:34]

sievers@chromium.org changed reviewers:
+ piman@chromium.org

[no sievers, 2014-09-29 23:05:53]

ptal

looks like everything uses delegated rendering or composite-to-mailbox now?

[no sievers, 2014-09-29 23:14:52]

Hmm I think there is a lot more code that can be deleted.

[no sievers, 2014-09-30 00:18:15]

sievers@chromium.org changed reviewers:
+ ccameron@chromium.org

[no sievers, 2014-09-30 00:18:37]

+ccameron for mac

[no sievers, 2014-09-30 00:48:02]

https://codereview.chromium.org/615503004/diff/80001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_mac.mm (left):

https://codereview.chromium.org/615503004/diff/80001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_mac.mm:1698: //
http://crbug.com/255608
Is this comment bug obsolete in the new rendering model, what about the bug?
AcceleratedSurfaceRelease() doesn't do anything now.

[ccameron, 2014-09-30 01:13:02]

Mac bits lgtm

https://codereview.chromium.org/615503004/diff/80001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_mac.mm (left):

https://codereview.chromium.org/615503004/diff/80001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_mac.mm:1698: //
http://crbug.com/255608
On 2014/09/30 00:48:01, sievers wrote:
> Is this comment bug obsolete in the new rendering model, what about the bug?
> AcceleratedSurfaceRelease() doesn't do anything now.

Yes, this is obsolete now.

[piman, 2014-09-30 03:06:47]

LGTM. Nice cleanup!

I think in the future we can remove the NullTransportSurface, I think all it
does now is set up the UI preemption, and provide an "onscreen" surface for the
GPU memory manager to implement the "visible" bit, but there's probably simpler
ways of doing this. At that point we can make the renderer stop using
CreateViewCommandBuffer and remove a bunch of logic.

https://codereview.chromium.org/615503004/diff/100001/content/common/gpu/null...
File content/common/gpu/null_transport_surface.cc (right):

https://codereview.chromium.org/615503004/diff/100001/content/common/gpu/null...
content/common/gpu/null_transport_surface.cc:53: NOTREACHED();
nit: technically, the client code could call swap and reach this code.

[Fady Samuel, 2014-09-30 15:33:11]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2014-09-30 15:33:12]

Yaay! render_widget_host_view_guest lgtm!

[no sievers, 2014-09-30 17:21:15]

sievers@chromium.org changed reviewers:
+ tsepez@chromium.org

[no sievers, 2014-09-30 17:21:33]

+tsepez@ for IPC msg removal

https://codereview.chromium.org/615503004/diff/100001/content/common/gpu/null...
File content/common/gpu/null_transport_surface.cc (right):

https://codereview.chromium.org/615503004/diff/100001/content/common/gpu/null...
content/common/gpu/null_transport_surface.cc:53: NOTREACHED();
On 2014/09/30 03:06:47, piman (Very slow to review) wrote:
> nit: technically, the client code could call swap and reach this code.

Changed to NOTIMPLEMENTED().

[Tom Sepez, 2014-09-30 17:49:38]

Rubberstamp LGTM on deleting IPC messages.  Thanks!

[no sievers, 2014-09-30 17:52:37]

sievers@chromium.org changed reviewers:
+ sky@chromium.org

[no sievers, 2014-09-30 17:53:14]

+sky for ui/gfx/native_widget_types.h where I merged two enums into one

[no sievers, 2014-09-30 18:55:04]

The CQ bit was checked by sievers@chromium.org

[commit-bot: I haz the power, 2014-09-30 18:57:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/615503004/120001

[sky, 2014-09-30 19:21:49]

LGTM

[commit-bot: I haz the power, 2014-09-30 20:17:00]

Committed patchset #7 (id:120001) as 3be2e7bd57894cd4e053da1e0fb3a097e2342b07

[commit-bot: I haz the power, 2014-09-30 20:17:42]

Patchset 7 (id:??) landed as
https://crrev.com/ef40ec9021eea9fe5122c155ff5480affa41a577
Cr-Commit-Position: refs/heads/master@{#297490}