chrome/browser/supervised_user/supervised_user_registration_utility_unittest.cc - Issue 615493005: c/b/supervised_user: Use range-based for where appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/supervised_user_registration_utility_unittest.cc

Issue 615493005: c/b/supervised_user: Use range-based for where appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/supervised_user_pref_store.cc ('k') | chrome/browser/supervised_user/supervised_user_service.cc » ('j') | chrome/browser/supervised_user/supervised_user_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/supervised_user_registration_utility_unittest.cc

diff --git a/chrome/browser/supervised_user/supervised_user_registration_utility_unittest.cc b/chrome/browser/supervised_user/supervised_user_registration_utility_unittest.cc

index a3b81f4cff9b71a936017eba3c21fc16accf19f4..dd106fb1185a597d9536a13eedf859045edc7707 100644

--- a/chrome/browser/supervised_user/supervised_user_registration_utility_unittest.cc

+++ b/chrome/browser/supervised_user/supervised_user_registration_utility_unittest.cc

@@ -215,11 +215,10 @@ SupervisedUserRegistrationUtilityTest::GetRegistrationUtility() {

void SupervisedUserRegistrationUtilityTest::Acknowledge() {

SyncChangeList new_changes;

- const SyncChangeList& changes = change_processor()->changes();

- for (SyncChangeList::const_iterator it = changes.begin(); it != changes.end();

- ++it) {

- EXPECT_EQ(SyncChange::ACTION_ADD, it->change_type());

- ::sync_pb::EntitySpecifics specifics = it->sync_data().GetSpecifics();

+ for (const auto& sync_change : change_processor()->changes()) {

+ EXPECT_EQ(SyncChange::ACTION_ADD, sync_change.change_type());

+ ::sync_pb::EntitySpecifics specifics =

+ sync_change.sync_data().GetSpecifics();

EXPECT_FALSE(specifics.managed_user().acknowledged());

specifics.mutable_managed_user()->set_acknowledged(true);

new_changes.push_back(