content/browser/service_worker/service_worker_request_handler_unittest.cc - Issue 615493003: [ServiceWorker] Plumbing the request credentials mode to the ServiceWorker. [2/2 chromium]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_request_handler_unittest.cc

Issue 615493003: [ServiceWorker] Plumbing the request credentials mode to the ServiceWorker. [2/2 chromium] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix GetFetchCredentialsMode Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_request_handler.cc ('k') | content/browser/service_worker/service_worker_url_request_job.h » ('j') | content/browser/service_worker/service_worker_url_request_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_request_handler_unittest.cc

diff --git a/content/browser/service_worker/service_worker_request_handler_unittest.cc b/content/browser/service_worker/service_worker_request_handler_unittest.cc

index f51ca7f7dd6aa83aa776fceca879c41eec6d448b..c4dda14573bc175c692de177bd6b744b7ea3921e 100644

--- a/content/browser/service_worker/service_worker_request_handler_unittest.cc

+++ b/content/browser/service_worker/service_worker_request_handler_unittest.cc

@@ -83,14 +83,14 @@ class ServiceWorkerRequestHandlerTest : public testing::Test {

scoped_ptr<net::URLRequest> request = url_request_context_.CreateRequest(

kDocUrl, net::DEFAULT_PRIORITY, &url_request_delegate_, NULL);

request->set_method(method);

- FetchRequestMode request_mode = FETCH_REQUEST_MODE_NO_CORS;

ServiceWorkerRequestHandler::InitializeHandler(request.get(),

context_wrapper(),

&blob_storage_context_,

kMockRenderProcessId,

kMockProviderId,

skip_service_worker,

- request_mode,

+ FETCH_REQUEST_MODE_NO_CORS,

+ FETCH_CREDENTIALS_MODE_OMIT,

resource_type,

NULL);

return ServiceWorkerRequestHandler::GetHandler(request.get()) != NULL;