Credential Manager: Extract browser-side IPC to a stand-alone dispatcher.

components/password_manager/content/browser/content_credential_manager_dispatcher.h

Index: components/password_manager/content/browser/content_credential_manager_dispatcher.h
diff --git a/components/password_manager/content/browser/content_credential_manager_dispatcher.h b/components/password_manager/content/browser/content_credential_manager_dispatcher.h
new file mode 100644
index 0000000000000000000000000000000000000000..1e0b88f01aa13bda98aa1bde956eb9cee90f13b7
--- /dev/null
+++ b/components/password_manager/content/browser/content_credential_manager_dispatcher.h
@@ -0,0 +1,54 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGER_DISPATCHER_H_
+#define COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGER_DISPATCHER_H_
+
+#include "base/basictypes.h"

[vabr (Chromium), 2014/09/29 11:05:27]

nit: Do you really need this, or just base/macros.h?

+#include "components/password_manager/core/browser/credential_manager_dispatcher.h"
+#include "content/public/browser/web_contents_observer.h"
+
+class GURL;
+
+namespace content {
+class WebContents;
+}
+
+namespace password_manager {
+
+class PasswordManagerClient;
+struct CredentialInfo;
+
+class ContentCredentialManagerDispatcher : public CredentialManagerDispatcher,
+                                           public content::WebContentsObserver {
+ public:
+  ContentCredentialManagerDispatcher(content::WebContents* web_contents,
+                                     PasswordManagerClient* client);
+  virtual ~ContentCredentialManagerDispatcher();
+
+  // CredentialManagerDispatcher implementation.
+  virtual void OnNotifyFailedSignIn(
+      int request_id,
+      const password_manager::CredentialInfo&) OVERRIDE;
+  virtual void OnNotifySignedIn(
+      int request_id,
+      const password_manager::CredentialInfo&) OVERRIDE;
+  virtual void OnNotifySignedOut(int request_id) OVERRIDE;
+  virtual void OnRequestCredential(
+      int request_id,
+      bool zero_click_only,
+      const std::vector<GURL>& federations) OVERRIDE;
+
+  // content::WebContentsObserver overrides.
+  virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
+
+ private:
+  PasswordManagerClient* client_;

[vabr (Chromium), 2014/09/29 11:05:27]

Since |client_| does not appear to be used in the code yet, would you mind
adding a TODO comment explaining the plans (as an alternative to removing it
completely)?

+
+  DISALLOW_COPY_AND_ASSIGN(ContentCredentialManagerDispatcher);
+};
+
+}  // namespace password_manager
+
+#endif  // COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGER_DISPATCHER_H_