Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 615453002: Change the size in the App Info dialog to always display in MB (Closed)

Created:
6 years, 2 months ago by sashab
Modified:
6 years, 2 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change the size in the App Info dialog to always display in MB Changed the size in the App Info dialog to always display in MB, no matter the size of the app. If the app is less than 1 MB, display '< 1 MB' instead of the size. BUG=398717 Committed: https://crrev.com/142d2bdbbe41338204e6c99b5f43a1b9d61e3e95 Cr-Commit-Position: refs/heads/master@{#297365}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M chrome/app/generated_resources.grd View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
sashab
Approved by UI (ainslie@). See bug for details.
6 years, 2 months ago (2014-09-29 08:31:29 UTC) #2
tapted
lgtm https://codereview.chromium.org/615453002/diff/1/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc File chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc (right): https://codereview.chromium.org/615453002/diff/1/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc#newcode326 chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc:326: const int kOneMegabyteInBytes = 1024 * 1024; nit: ...
6 years, 2 months ago (2014-09-30 01:36:51 UTC) #3
sashab
https://codereview.chromium.org/615453002/diff/1/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc File chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc (right): https://codereview.chromium.org/615453002/diff/1/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc#newcode326 chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc:326: const int kOneMegabyteInBytes = 1024 * 1024; On 2014/09/30 ...
6 years, 2 months ago (2014-09-30 02:58:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615453002/20001
6 years, 2 months ago (2014-09-30 03:05:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 80bbd0e5905ac4cc0b233e8f7e59c68f99cc24d3
6 years, 2 months ago (2014-09-30 05:07:39 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 05:08:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/142d2bdbbe41338204e6c99b5f43a1b9d61e3e95
Cr-Commit-Position: refs/heads/master@{#297365}

Powered by Google App Engine
This is Rietveld 408576698