Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 615423006: Squeeze the layout of expression nodes a bit. (Closed)

Created:
6 years, 2 months ago by Sven Panne
Modified:
6 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Squeeze the layout of expression nodes a bit. Again 112MB less peak memory usage in the bug mentioned below. :-) Routed all writes to to_boolean_types_ through its setter on the way. BUG=417697 LOG=y R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M src/ast.h View 2 chunks +11 lines, -6 lines 0 comments Download
M src/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Sven Panne
6 years, 2 months ago (2014-10-02 11:46:23 UTC) #2
mvstanton
lgtm
6 years, 2 months ago (2014-10-02 11:49:17 UTC) #3
Sven Panne
6 years, 2 months ago (2014-10-02 11:53:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24393 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698