Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: content/browser/service_worker/service_worker_url_request_job.cc

Issue 615413002: [ServiceWorker] Don't pass DevTools related HTTP headers to the ServiceWorker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove space Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_network_transaction.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_url_request_job.cc
diff --git a/content/browser/service_worker/service_worker_url_request_job.cc b/content/browser/service_worker/service_worker_url_request_job.cc
index 191988461791f9989fb890ecf8a2624aff876aa2..60a6d84419fe4e6386dda2e95658d87c9c5c8c5f 100644
--- a/content/browser/service_worker/service_worker_url_request_job.cc
+++ b/content/browser/service_worker/service_worker_url_request_job.cc
@@ -30,6 +30,17 @@
namespace content {
+namespace {
+
+// Keep in sync with kDevToolsRequestInitiator and
+// kDevToolsEmulateNetworkConditionsClientId defined in
+// devtools_network_transaction.cc and InspectorResourceAgent.cpp.
+const char kDevToolsRequestInitiator[] = "X-DevTools-Request-Initiator";
+const char kDevToolsEmulateNetworkConditionsClientId[] =
+ "X-DevTools-Emulate-Network-Conditions-Client-Id";
+
+} // namespace
+
ServiceWorkerURLRequestJob::ServiceWorkerURLRequestJob(
net::URLRequest* request,
net::NetworkDelegate* network_delegate,
@@ -274,8 +285,13 @@ ServiceWorkerURLRequestJob::CreateFetchRequest() {
request->url = request_->url();
request->method = request_->method();
const net::HttpRequestHeaders& headers = request_->extra_request_headers();
- for (net::HttpRequestHeaders::Iterator it(headers); it.GetNext();)
+ for (net::HttpRequestHeaders::Iterator it(headers); it.GetNext();) {
+ if (it.name() == kDevToolsRequestInitiator ||
+ it.name() == kDevToolsEmulateNetworkConditionsClientId) {
+ continue;
+ }
request->headers[it.name()] = it.value();
+ }
request->blob_uuid = blob_uuid;
request->blob_size = blob_size;
request->referrer = GURL(request_->referrer());
« no previous file with comments | « chrome/browser/devtools/devtools_network_transaction.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698