Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 615393005: Merge to 39: PPAPI: Never re-enter JavaScript for PostMessage. (Closed)

Created:
6 years, 2 months ago by dmichael (off chromium)
Modified:
6 years, 2 months ago
Reviewers:
raymes
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@2171
Project:
chromium
Visibility:
Public.

Description

Merge to 39: PPAPI: Never re-enter JavaScript for PostMessage. Blocking renderer->plugin messages can be interrupted by any message from the plugin->renderer (even async ones). So while handline a blocking message, such as HandleInputEvent or HandleBlockingMessage, it's currently possible to re-enter JavaScript. This patch makes that impossible by queueing up Plugin->Renderer messages sent via PPB_Messaging::PostMessage while any renderer->plugin sync message is on the stack. BUG=384528 TBR=raymes Committed: https://crrev.com/f73075c99b5ba30e8d62dc5f13fdfb210d0fc506 Cr-Commit-Position: refs/heads/master@{#296311} Committed: https://crrev.com/3fe4ceee750b2cd130bd402de3d371d8518c3eba Cr-Commit-Position: refs/heads/master@{#296807} Review URL: https://codereview.chromium.org/589213003 Cr-Commit-Position: refs/heads/master@{#297308} (cherry picked from commit 6b328f3db4b55fa299b6cfac9a30efbc47a2ad26) Committed: https://chromium.googlesource.com/chromium/src/+/541bc0b0a7ab7e6bf81927a3bef0e3068b34099a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -71 lines) Patch
M content/renderer/pepper/host_dispatcher_wrapper.h View 3 chunks +6 lines, -1 line 0 comments Download
M content/renderer/pepper/host_dispatcher_wrapper.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M content/renderer/pepper/message_channel.h View 6 chunks +39 lines, -8 lines 0 comments Download
M content/renderer/pepper/message_channel.cc View 7 chunks +61 lines, -20 lines 0 comments Download
M content/renderer/pepper/pepper_hung_plugin_filter.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ppapi/proxy/dispatcher.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ppapi/proxy/dispatcher.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ppapi/proxy/host_dispatcher.h View 7 chunks +19 lines, -6 lines 0 comments Download
M ppapi/proxy/host_dispatcher.cc View 4 chunks +19 lines, -7 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 4 chunks +2 lines, -11 lines 0 comments Download
M ppapi/tests/test_message_handler.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dmichael (off chromium)
6 years, 2 months ago (2014-10-01 17:39:40 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
541bc0b0a7ab7e6bf81927a3bef0e3068b34099a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698