Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

Issue 615383002: Credential Manager: Return the first valid item from the PasswordStore. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
diff --git a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
index 7cb43fb5071a42b03c5fcf56a7710788bf95f7c4..4b2c40d09120c5b94e9ac325dfbcd1e322cc85a1 100644
--- a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
+++ b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
@@ -12,6 +12,7 @@
#include "components/password_manager/content/common/credential_manager_types.h"
#include "components/password_manager/core/browser/stub_password_manager_client.h"
#include "components/password_manager/core/browser/test_password_store.h"
+#include "content/public/browser/web_contents.h"
#include "content/public/test/mock_render_process_host.h"
#include "content/public/test/test_renderer_host.h"
#include "testing/gmock/include/gmock/gmock.h"
@@ -62,6 +63,15 @@ class ContentCredentialManagerDispatcherTest
client_.reset(new TestPasswordManagerClient(store_.get()));
dispatcher_.reset(
new ContentCredentialManagerDispatcher(web_contents(), client_.get()));
+
+ NavigateAndCommit(GURL("https://example.com/test.html"));
+
+ form_.username_value = base::ASCIIToUTF16("Username");
+ form_.display_name = base::ASCIIToUTF16("Display Name");
+ form_.password_value = base::ASCIIToUTF16("Password");
+ form_.origin = web_contents()->GetLastCommittedURL().GetOrigin();
+ form_.signon_realm = form_.origin.spec();
+ form_.scheme = autofill::PasswordForm::SCHEME_HTML;
}
virtual void TearDown() OVERRIDE {
@@ -71,7 +81,8 @@ class ContentCredentialManagerDispatcherTest
ContentCredentialManagerDispatcher* dispatcher() { return dispatcher_.get(); }
- private:
+ protected:
+ autofill::PasswordForm form_;
scoped_refptr<TestPasswordStore> store_;
scoped_ptr<ContentCredentialManagerDispatcher> dispatcher_;
scoped_ptr<TestPasswordManagerClient> client_;
@@ -117,7 +128,23 @@ TEST_F(ContentCredentialManagerDispatcherTest,
}
TEST_F(ContentCredentialManagerDispatcherTest,
- CredentialManagerOnRequestCredential) {
+ CredentialManagerOnRequestCredentialWithEmptyPasswordStore) {
+ std::vector<GURL> federations;
+ dispatcher()->OnRequestCredential(kRequestId, false, federations);
+
+ RunAllPendingTasks();
+
+ const uint32 kMsgID = CredentialManagerMsg_RejectCredentialRequest::ID;
+ const IPC::Message* message =
+ process()->sink().GetFirstMessageMatching(kMsgID);
+ EXPECT_TRUE(message);
+ process()->sink().ClearMessages();
+}
+
+TEST_F(ContentCredentialManagerDispatcherTest,
+ CredentialManagerOnRequestCredentialWithFullPasswordStore) {
+ store_->AddLogin(form_);
+
std::vector<GURL> federations;
dispatcher()->OnRequestCredential(kRequestId, false, federations);
@@ -132,6 +159,8 @@ TEST_F(ContentCredentialManagerDispatcherTest,
TEST_F(ContentCredentialManagerDispatcherTest,
CredentialManagerOnRequestCredentialWhileRequestPending) {
+ store_->AddLogin(form_);
+
std::vector<GURL> federations;
dispatcher()->OnRequestCredential(kRequestId, false, federations);
dispatcher()->OnRequestCredential(kRequestId, false, federations);

Powered by Google App Engine
This is Rietveld 408576698