Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: components/domain_reliability/monitor_unittest.cc

Issue 615313006: Domain Reliability: Get correct reporting pref once, on startup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix ordering on SetDiscardUploads Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/domain_reliability/monitor_unittest.cc
diff --git a/components/domain_reliability/monitor_unittest.cc b/components/domain_reliability/monitor_unittest.cc
index 1dbe5b3d78e30b12339287413b6ee5caa171b328..7cc14b1fced1dfd3e38baee39b4ba1600b298050 100644
--- a/components/domain_reliability/monitor_unittest.cc
+++ b/components/domain_reliability/monitor_unittest.cc
@@ -11,8 +11,6 @@
#include "base/bind.h"
#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_loop_proxy.h"
-#include "base/prefs/pref_registry_simple.h"
-#include "base/prefs/testing_pref_service.h"
#include "base/test/test_simple_task_runner.h"
#include "components/domain_reliability/baked_in_configs.h"
#include "components/domain_reliability/beacon.h"
@@ -36,8 +34,6 @@ typedef std::vector<DomainReliabilityBeacon> BeaconVector;
static const size_t kAlwaysReportIndex = 0u;
static const size_t kNeverReportIndex = 1u;
-static const char* kPrefName = "reporting_enabled";
-
scoped_refptr<net::HttpResponseHeaders> MakeHttpResponseHeaders(
const std::string& headers) {
return scoped_refptr<net::HttpResponseHeaders>(
@@ -57,12 +53,9 @@ class DomainReliabilityMonitorTest : public testing::Test {
url_request_context_getter_(
new net::TestURLRequestContextGetter(network_task_runner_)),
time_(new MockTime()),
- pref_service_(CreatePrefService()),
monitor_("test-reporter",
pref_task_runner_,
network_task_runner_,
- pref_service_.get(),
- kPrefName,
scoped_ptr<MockableTime>(time_)),
context_(NULL) {
monitor_.MoveToNetworkThread();
@@ -70,13 +63,6 @@ class DomainReliabilityMonitorTest : public testing::Test {
context_ = monitor_.AddContextForTesting(MakeTestConfig());
}
- static PrefService* CreatePrefService() {
- TestingPrefServiceSimple* prefs = new TestingPrefServiceSimple();
- prefs->registry()->RegisterBooleanPref(kPrefName, false);
- prefs->SetUserPref(kPrefName, new base::FundamentalValue(true));
- return prefs;
- }
-
static RequestInfo MakeRequestInfo() {
RequestInfo request;
request.status = net::URLRequestStatus();
@@ -131,7 +117,6 @@ class DomainReliabilityMonitorTest : public testing::Test {
scoped_refptr<base::TestSimpleTaskRunner> network_task_runner_;
scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;
MockTime* time_;
- scoped_ptr<PrefService> pref_service_;
DomainReliabilityMonitor monitor_;
DomainReliabilityContext* context_;
DomainReliabilityMonitor::RequestInfo request_;

Powered by Google App Engine
This is Rietveld 408576698