Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: chrome/browser/browsing_data/browsing_data_remover_unittest.cc

Issue 615313006: Domain Reliability: Get correct reporting pref once, on startup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a couple more things Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browsing_data/browsing_data_remover.h" 5 #include "chrome/browser/browsing_data/browsing_data_remover.h"
6 6
7 #include <set> 7 #include <set>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 582 matching lines...) Expand 10 before | Expand all | Expand 10 after
593 DISALLOW_COPY_AND_ASSIGN(RemoveLocalStorageTester); 593 DISALLOW_COPY_AND_ASSIGN(RemoveLocalStorageTester);
594 }; 594 };
595 595
596 class MockDomainReliabilityService : public DomainReliabilityService { 596 class MockDomainReliabilityService : public DomainReliabilityService {
597 public: 597 public:
598 MockDomainReliabilityService() : clear_count_(0) {} 598 MockDomainReliabilityService() : clear_count_(0) {}
599 599
600 virtual ~MockDomainReliabilityService() {} 600 virtual ~MockDomainReliabilityService() {}
601 601
602 virtual scoped_ptr<DomainReliabilityMonitor> CreateMonitor( 602 virtual scoped_ptr<DomainReliabilityMonitor> CreateMonitor(
603 scoped_refptr<base::SingleThreadTaskRunner> network_task_runner, 603 scoped_refptr<base::SingleThreadTaskRunner> network_task_runner)
604 PrefService* local_state_pref_service, 604 OVERRIDE {
Mike West 2014/10/06 18:26:19 Nit: s/OVERRIDE/override/g You could do this in a
605 const char* reporting_pref_name) OVERRIDE {
606 NOTREACHED(); 605 NOTREACHED();
607 return scoped_ptr<DomainReliabilityMonitor>(); 606 return scoped_ptr<DomainReliabilityMonitor>();
608 } 607 }
609 608
610 virtual void ClearBrowsingData(DomainReliabilityClearMode clear_mode, 609 virtual void ClearBrowsingData(DomainReliabilityClearMode clear_mode,
611 const base::Closure& callback) OVERRIDE { 610 const base::Closure& callback) OVERRIDE {
612 clear_count_++; 611 clear_count_++;
613 last_clear_mode_ = clear_mode; 612 last_clear_mode_ = clear_mode;
614 callback.Run(); 613 callback.Run();
615 } 614 }
(...skipping 1214 matching lines...) Expand 10 before | Expand all | Expand 10 after
1830 EXPECT_EQ(1u, tester.clear_count()); 1829 EXPECT_EQ(1u, tester.clear_count());
1831 EXPECT_EQ(CLEAR_CONTEXTS, tester.last_clear_mode()); 1830 EXPECT_EQ(CLEAR_CONTEXTS, tester.last_clear_mode());
1832 } 1831 }
1833 1832
1834 TEST_F(BrowsingDataRemoverTest, DomainReliability_NoMonitor) { 1833 TEST_F(BrowsingDataRemoverTest, DomainReliability_NoMonitor) {
1835 BlockUntilBrowsingDataRemoved( 1834 BlockUntilBrowsingDataRemoved(
1836 BrowsingDataRemover::EVERYTHING, 1835 BrowsingDataRemover::EVERYTHING,
1837 BrowsingDataRemover::REMOVE_HISTORY | 1836 BrowsingDataRemover::REMOVE_HISTORY |
1838 BrowsingDataRemover::REMOVE_COOKIES, false); 1837 BrowsingDataRemover::REMOVE_COOKIES, false);
1839 } 1838 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698