Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: tools/perf/measurements/thread_times_unittest.py

Issue 615253007: Telemetry: Correct typo in _timeline_controller identifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add test Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/thread_times.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/thread_times_unittest.py
diff --git a/tools/perf/measurements/thread_times_unittest.py b/tools/perf/measurements/thread_times_unittest.py
index f86bd33d3b55ae326a9a8a79e33811408b5c69dd..cd6a7552377172a9e7ddf460a1f4d319c6a6ef22 100644
--- a/tools/perf/measurements/thread_times_unittest.py
+++ b/tools/perf/measurements/thread_times_unittest.py
@@ -44,6 +44,13 @@ class ThreadTimesUnitTest(page_test_test_case.PageTestTestCase):
cpu_time = results.FindAllPageSpecificValuesNamed(cpu_time_name)
self.assertEquals(len(cpu_time), 1)
+ def testWithSilkFlags(self):
+ ps = self.CreatePageSetFromFileInUnittestDataDir('scrollable_page.html')
+ measurement = thread_times.ThreadTimes()
+ self._options.report_silk_results = True
+ self._options.report_silk_details = True
nednguyen 2014/10/01 22:41:53 Duplication.
jbroman 2014/10/02 14:24:46 Nope, these are two separate flags. I've split thi
+ results = self.RunMeasurement(measurement, ps, options = self._options)
+ self.assertEquals(0, len(results.failures))
def testCleanUpTrace(self):
self.TestTracingCleanedUp(thread_times.ThreadTimes, self._options)
« no previous file with comments | « tools/perf/measurements/thread_times.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698