IDL compiler: [CheckSecurity=Frame] interfaces (initial)

Source/bindings/scripts/unstable/v8_interface.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 49 matching lines @@
     'wtf/UnusedParam.h',
 ])
 
 
 def generate_interface(interface):
     includes.clear()
     includes.update(INTERFACE_CPP_INCLUDES)
     extended_attributes = interface.extended_attributes
     v8_class_name = v8_utilities.v8_class_name(interface)
 
+    is_check_security = 'CheckSecurity' in extended_attributes
+    if is_check_security:
+        includes.update(['bindings/v8/BindingSecurity.h',
+                         'bindings/v8/ExceptionMessages.h',
+                         'bindings/v8/ExceptionState.h'])
+
     template_contents = {
         'cpp_class_name': cpp_name(interface),
         'header_includes': INTERFACE_H_INCLUDES,
         'interface_name': interface.name,
         'is_active_dom_object': 'ActiveDOMObject' in extended_attributes,
+        'is_check_security': is_check_security,
         'v8_class_name': v8_class_name,
     }
 
     template_contents.update({
         'constants': [generate_constant(constant) for constant in interface.constants],
         'do_not_check_constants': 'DoNotCheckConstants' in extended_attributes,
     })
 
     attributes = [v8_attributes.generate_attribute(interface, attribute)
                   for attribute in interface.attributes]
     template_contents.update({
         'attributes': attributes,
         'has_accessors': any(attribute['is_expose_js_accessors'] for attribute in attributes),
         'has_constructor_attributes': any(attribute['constructor_type'] for attribute in attributes),
         'has_per_context_enabled_attributes': any(attribute['per_context_enabled_function_name'] for attribute in attributes),
         'has_replaceable_attributes': any(attribute['is_replaceable'] for attribute in attributes),
     })
 
     methods = [v8_methods.generate_method(interface, method)
                for method in interface.operations]
     generate_overloads(methods)
     template_contents.update({
         'has_per_context_enabled_methods': any(method['per_context_enabled_function_name'] for method in methods),
         'methods': methods,
+        'standard_methods':

[Nils Barth (inactive), 2013/11/19 06:56:06]

Moved from templates to here b/c need to do an overall check,
otherwise generates an empty array.

[haraken, 2013/11/19 07:05:06]

standard_methods => has_standard_method ?

BTW, would you summarize what method is a non-standard method for me? I'm
curious why the distinction between standard/non-standard is needed.

[Nils Barth (inactive), 2013/11/19 08:10:09]

Rearranged to compute a value for each method,
so we can use an overall flag and a filter in the template.
I've renamed this to |do_generate_method_configuration|,
as that's what it does.
Other methods (custom signature etc.) have their configuration
set somewhere else, rather than in the main
V8DOMConfiguration::MethodConfiguration
array.

[haraken, 2013/11/19 08:52:47]

It's OK in this CL, but the core issue is we have configuration code in multiple
places.
What is 'etc'? I want to understand what makes it harder to unify these
configurations.

[haraken, 2013/11/19 08:58:05]

Supporting indexed/named properties will also add more complexity to the
configuration code, so we might want to clean up the configuration code at this
point.

[Nils Barth (inactive), 2013/11/20 06:36:23]

The full check is in v8_methods.py:
'do_not_check_signature': not(this_custom_signature or is_static or
    v8_utilities.has_extended_attribute(method,
        ['DoNotCheckSignature', 'NotEnumerable', 'ReadOnly',
         'RuntimeEnabled', 'Unforgeable'])),

There are various reasons for installation different places;
some of these are:
If [RuntimeEnabled] we need to check the runtime enabled function before
installing the attributes,
if [PerContextEnabled] we need to check the per context enabled function.

[Nils Barth (inactive), 2013/11/20 06:36:23]

Got it; let's do it then!

+            [method for method in methods if
+             method['do_not_check_signature'] and
+             not method['per_context_enabled_function_name'] and
+             # For overloaded methods, only generate one accessor
+             ('overload_index' not in method or method['overload_index'] == 1)],
     })
 
     return template_contents
 
 
 # [DeprecateAs], [Reflect], [RuntimeEnabled]
 def generate_constant(constant):
     # (Blink-only) string literals are unquoted in tokenizer, must be re-quoted
     # in C++.
     if constant.idl_type == 'DOMString':
@@ skipping 111 matching lines @@
                             '%s->IsString()' % cpp_value,
                             '%s->IsObject()' % cpp_value])
     if v8_types.array_or_sequence_type(idl_type):
         return '%s->IsArray()' % cpp_value
     if v8_types.is_wrapper_type(idl_type):
         type_check = 'V8{idl_type}::hasInstance({cpp_value}, info.GetIsolate(), worldType(info.GetIsolate()))'.format(idl_type=idl_type, cpp_value=cpp_value)
         if argument['is_nullable']:
             type_check = ' || '.join(['%s->IsNull()' % cpp_value, type_check])
         return type_check
     return None