cros: Use AlertDialog for remora device requisition.

cros: Use AlertDialog for remora device requisition.

BUG=313854
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233547

[zel, 2013-11-06 07:21:15]

lgtm

[commit-bot: I haz the power, 2013-11-06 07:43:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/61523002/40001

[commit-bot: I haz the power, 2013-11-06 11:24:35]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[xiyuan, 2013-11-06 19:01:41]

dbeam@, what do you think of the dialog.js change? It makes AlertDialog could
only be dismissed using the "ok" button.

[Dan Beam, 2013-11-07 00:12:36]

lgtm (seems fine)

https://codereview.chromium.org/61523002/diff/330001/chrome/browser/resources...
File chrome/browser/resources/chromeos/login/display_manager.js (right):

https://codereview.chromium.org/61523002/diff/330001/chrome/browser/resources...
chrome/browser/resources/chromeos/login/display_manager.js:591: * Shows the
special remora device requisition prompt.
@private

[xiyuan, 2013-11-07 00:25:56]

https://codereview.chromium.org/61523002/diff/330001/chrome/browser/resources...
File chrome/browser/resources/chromeos/login/display_manager.js (right):

https://codereview.chromium.org/61523002/diff/330001/chrome/browser/resources...
chrome/browser/resources/chromeos/login/display_manager.js:591: * Shows the
special remora device requisition prompt.
On 2013/11/07 00:12:37, Dan Beam wrote:
> @private

Done. Only changed this one since I want to keep the CL small for merging.

[commit-bot: I haz the power, 2013-11-07 00:29:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/61523002/440001

[commit-bot: I haz the power, 2013-11-07 08:22:31]

Change committed as 233547

[mtomasz, 2014-01-08 06:43:02]

On 2013/11/06 19:01:41, xiyuan wrote:
> dbeam@, what do you think of the dialog.js change? It makes AlertDialog could
> only be dismissed using the "ok" button.

Why did you need this change? In Files app we show alert dialogs, and now it
became impossible to hide them by pressing Escape.

[mtomasz, 2014-01-08 07:10:10]

On 2014/01/08 06:43:02, mtomasz wrote:
> On 2013/11/06 19:01:41, xiyuan wrote:
> > dbeam@, what do you think of the dialog.js change? It makes AlertDialog
could
> > only be dismissed using the "ok" button.
> 
> Why did you need this change? In Files app we show alert dialogs, and now it
> became impossible to hide them by pressing Escape.

This also broke hiding the share dialog via Escape. Can we rollback this change
or at least the webui change?

[xiyuan, 2014-01-08 17:12:05]

On 2014/01/08 07:10:10, mtomasz wrote:
> On 2014/01/08 06:43:02, mtomasz wrote:
> > On 2013/11/06 19:01:41, xiyuan wrote:
> > > dbeam@, what do you think of the dialog.js change? It makes AlertDialog
> could
> > > only be dismissed using the "ok" button.
> > 
> > Why did you need this change? In Files app we show alert dialogs, and now it
> > became impossible to hide them by pressing Escape.
> 
> This also broke hiding the share dialog via Escape. Can we rollback this
change
> or at least the webui change?

It's okay to revert the webui change since the final UI no longer uses it.

The reason for doing that in the CL is because it does not make much sense for
an AlertDialog to have a "cancel" button because that does not provide a
different functionality as pressing "ok" button and might confuse users by
making them think "cancel" would cancel what the AlertDialog says.

[mtomasz, 2014-01-09 00:14:41]

On 2014/01/08 17:12:05, xiyuan wrote:
> On 2014/01/08 07:10:10, mtomasz wrote:
> > On 2014/01/08 06:43:02, mtomasz wrote:
> > > On 2013/11/06 19:01:41, xiyuan wrote:
> > > > dbeam@, what do you think of the dialog.js change? It makes AlertDialog
> > could
> > > > only be dismissed using the "ok" button.
> > > 
> > > Why did you need this change? In Files app we show alert dialogs, and now
it
> > > became impossible to hide them by pressing Escape.
> > 
> > This also broke hiding the share dialog via Escape. Can we rollback this
> change
> > or at least the webui change?
> 
> It's okay to revert the webui change since the final UI no longer uses it.
> 
> The reason for doing that in the CL is because it does not make much sense for
> an AlertDialog to have a "cancel" button because that does not provide a
> different functionality as pressing "ok" button and might confuse users by
> making them think "cancel" would cancel what the AlertDialog says.

I agree, that we may want to refine behaviour of the Alert dialog.
But it should by dismissable by keyboard. Let's revert the dialog.js change as
for now.