Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 615213003: Upstream NFC beam URL sharing code and add it to ChromeShell. (Closed)

Created:
6 years, 2 months ago by aurimas (slooooooooow)
Modified:
6 years, 2 months ago
Reviewers:
Yaron, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Upstream NFC beam URL sharing code and add it to ChromeShell. BUG=417543 Committed: https://crrev.com/a683d267055e8b1cfd054986b8964b1a3456df55 Cr-Commit-Position: refs/heads/master@{#297549}

Patch Set 1 #

Patch Set 2 : Add OWNERS file #

Total comments: 2

Patch Set 3 : Start using uma :D #

Total comments: 1

Patch Set 4 : Updated sync shell manifest #

Messages

Total messages: 11 (3 generated)
aurimas (slooooooooow)
Hey Newton, PTAL. Aurimas
6 years, 2 months ago (2014-09-30 22:12:07 UTC) #2
newt (away)
lgtm after UMA fix https://chromiumcodereview.appspot.com/615213003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamCallback.java File chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamCallback.java (right): https://chromiumcodereview.appspot.com/615213003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamCallback.java#newcode115 chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamCallback.java:115: //UmaRecordAction.beamInvalidAppState(); uncomment this !!!!!
6 years, 2 months ago (2014-09-30 22:34:36 UTC) #3
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/615213003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamCallback.java File chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamCallback.java (right): https://chromiumcodereview.appspot.com/615213003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamCallback.java#newcode115 chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamCallback.java:115: //UmaRecordAction.beamInvalidAppState(); On 2014/09/30 22:34:36, newt wrote: > uncomment this ...
6 years, 2 months ago (2014-09-30 22:45:26 UTC) #4
aurimas (slooooooooow)
yfriedman@chromium.org for OWNERS review.
6 years, 2 months ago (2014-09-30 22:45:46 UTC) #6
Yaron
lgtm https://chromiumcodereview.appspot.com/615213003/diff/40001/chrome/android/shell/java/AndroidManifest.xml File chrome/android/shell/java/AndroidManifest.xml (right): https://chromiumcodereview.appspot.com/615213003/diff/40001/chrome/android/shell/java/AndroidManifest.xml#newcode22 chrome/android/shell/java/AndroidManifest.xml:22: <uses-permission android:name="android.permission.NFC"/> Please add to chrome/android/sync_shell/java/AndroidManifest.xml.
6 years, 2 months ago (2014-09-30 22:57:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615213003/60001
6 years, 2 months ago (2014-09-30 23:00:54 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 86c11f6faf9c6ee14564184ca814d0080ee071b3
6 years, 2 months ago (2014-09-30 23:48:49 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 23:49:45 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/a683d267055e8b1cfd054986b8964b1a3456df55
Cr-Commit-Position: refs/heads/master@{#297549}

Powered by Google App Engine
This is Rietveld 408576698