ui/display/chromeos/display_snapshot_virtual.h - Issue 615133002: Add support for a virtual display on ChromeOS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/display/chromeos/display_snapshot_virtual.h

Issue 615133002: Add support for a virtual display on ChromeOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix remaining comment periods (thanks achuithb@) Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ui/display/chromeos/display_configurator.cc ('K') | « ui/display/chromeos/display_configurator_unittest.cc ('k') | ui/display/chromeos/display_snapshot_virtual.cc » ('j') | ui/display/chromeos/display_snapshot_virtual.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_DISPLAY_TYPES_DISPLAY_SNAPSHOT_VIRTUAL_H_

	6 #define UI_DISPLAY_TYPES_DISPLAY_SNAPSHOT_VIRTUAL_H_

	7

	8 #include "ui/display/types/display_snapshot.h"

	9

	10 namespace ui {

	11

	12 class DisplaySnapshotVirtual : public DisplaySnapshot {
	Daniel Erat 2015/02/23 23:14:54 add a comment documenting what this class is for add a comment documenting what this class is for robert.bradford 2015/03/03 19:58:00 Done. Show quoted text On 2015/02/23 23:14:54, Daniel Erat wrote: > add a comment documenting what this class is for Done.
	13 public:

	14 DisplaySnapshotVirtual(uint32_t index, DisplayMode* mode);
	Daniel Erat 2015/02/23 23:14:54 add a comment documenting what \|index\| is and whet add a comment documenting what \|index\| is and whether ownership of \|mode\| is passed (and if it is, used scoped_ptr instead) robert.bradford 2015/03/03 19:58:00 The constructor prototype now looks like this: Di Show quoted text On 2015/02/23 23:14:54, Daniel Erat wrote: > add a comment documenting what \|index\| is and whether ownership of \|mode\| is > passed (and if it is, used scoped_ptr instead) The constructor prototype now looks like this: DisplaySnapshotVirtual(int64_t display_id, gfx::Size display_size);
	15 ~DisplaySnapshotVirtual() override;

	16

	17 // DisplaySnapshot overrides.

	18 std::string ToString() const override;

	19
	oshima 2015/02/24 19:43:21 private: private: robert.bradford 2015/03/03 19:58:00 Done. Show quoted text On 2015/02/24 19:43:21, oshima wrote: > private: Done.
	20 DISALLOW_COPY_AND_ASSIGN(DisplaySnapshotVirtual);

	21 };

	22

	23 } // namespace ui

	24

	25 #endif // UI_DISPLAY_TYPES_DISPLAY_SNAPSHOT_VIRTUAL_H_

OLD	NEW