components/content_settings/core/browser/content_settings_observable_provider.h - Issue 615083004: Use ThreadChecker rather than DCHECK_CURRENTLY_ON.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/content_settings_observable_provider.h

Issue 615083004: Use ThreadChecker rather than DCHECK_CURRENTLY_ON. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DCHECK testing_profile Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/base/testing_profile.cc ('k') | components/content_settings/core/browser/content_settings_observable_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/content_settings_observable_provider.h

diff --git a/components/content_settings/core/browser/content_settings_observable_provider.h b/components/content_settings/core/browser/content_settings_observable_provider.h

index 6c011e04ffdfab3a46b73dee2e7ac60dd9ffa5a2..cb6a01dde8156cd36c75d363f2263be72f1f4fde 100644

--- a/components/content_settings/core/browser/content_settings_observable_provider.h

+++ b/components/content_settings/core/browser/content_settings_observable_provider.h

@@ -8,6 +8,7 @@

#include <string>

#include "base/observer_list.h"

+#include "base/threading/thread_checker.h"

#include "components/content_settings/core/browser/content_settings_observer.h"

#include "components/content_settings/core/browser/content_settings_provider.h"

#include "components/content_settings/core/common/content_settings_pattern.h"

@@ -28,8 +29,10 @@ class ObservableProvider : public ProviderInterface {

ContentSettingsType content_type,

const std::string& resource_identifier);

void RemoveAllObservers();

+ bool CalledOnValidThread();

private:

+ base::ThreadChecker thread_checker_;

ObserverList<Observer, true> observer_list_;

};