chrome/browser/content_settings/content_settings_internal_extension_provider.cc - Issue 615083004: Use ThreadChecker rather than DCHECK_CURRENTLY_ON.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_internal_extension_provider.cc

Issue 615083004: Use ThreadChecker rather than DCHECK_CURRENTLY_ON. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DCHECK testing_profile Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_default_provider_unittest.cc ('k') | chrome/browser/content_settings/content_settings_override_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/content_settings_internal_extension_provider.cc

diff --git a/chrome/browser/content_settings/content_settings_internal_extension_provider.cc b/chrome/browser/content_settings/content_settings_internal_extension_provider.cc

index 6e65b80670debe36531a71fa9747f607d171e42e..ab4f54d15bc4d01c59897a95858c39b4706a1408 100644

--- a/chrome/browser/content_settings/content_settings_internal_extension_provider.cc

+++ b/chrome/browser/content_settings/content_settings_internal_extension_provider.cc

@@ -10,7 +10,6 @@

#include "components/content_settings/core/browser/content_settings_rule.h"

#include "components/content_settings/core/common/content_settings.h"

#include "components/content_settings/core/common/content_settings_pattern.h"

-#include "content/public/browser/browser_thread.h"

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_service.h"

#include "extensions/browser/extension_host.h"

@@ -155,7 +154,7 @@ void InternalExtensionProvider::Observe(int type,

}

void InternalExtensionProvider::ShutdownOnUIThread() {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK(CalledOnValidThread());

RemoveAllObservers();

registrar_.reset();

}