Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 615063004: gpu/khronos_glcts_support: WA suppress compile-time warnings on linux (Closed)

Created:
6 years, 2 months ago by U. Artie Eoff
Modified:
6 years, 2 months ago
CC:
chromium-reviews, piman+watch_chromium.org, chadv
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gpu/khronos_glcts_support: WA suppress compile-time warnings on linux Add various cflags/cflags_cc and disable clang chromium-style enforcement on third_party/khronos_glcts sourcecode and support. This is a workaround for various compile time warnings on desktop linux (e.g. Ubuntu 12.04) that are treated as errors (i.e. by -Werror). The source of these warnings are from the third_party/khronos_glcts sourcecode. With these workarounds the khronos_glcts_test is able to finish compilation. The plan is to eventually fix the third-party code so we can remove these workarounds. BUG=chromium:412865 R=piman@chromium.org, kbr@chromium.org TBR=piman@chromium.org TEST=export GYP_DEFINES="internal_khronos_glcts_tests=1" TEST=gclient runhooks TEST=ninja -C out/Release khronos_glcts_test TEST=./out/Release/khronos_glcts_test TEST=ninja -C out/Debug khronos_glcts_test TEST=./out/Debug/khronos_glcts_test Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>; Committed: https://crrev.com/66e31a6c026cd22fa2341d924f5ceb18652ec217 Cr-Commit-Position: refs/heads/master@{#297929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M gpu/khronos_glcts_support/khronos_glcts.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/khronos_glcts_support/khronos_glcts_cts.gyp View 1 chunk +12 lines, -0 lines 0 comments Download
M gpu/khronos_glcts_support/khronos_glcts_framework.gyp View 3 chunks +32 lines, -0 lines 0 comments Download
M gpu/khronos_glcts_support/khronos_glcts_gtf.gyp View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
U. Artie Eoff
Hello, I'd like you to review my code.
6 years, 2 months ago (2014-10-02 01:30:30 UTC) #1
Ken Russell (switch to Gerrit)
Thank you for this patch. I've verified locally that with one build fix to the ...
6 years, 2 months ago (2014-10-02 22:24:33 UTC) #2
Ken Russell (switch to Gerrit)
Note: that workaround's already been committed to the Chromium copy of the sources, and I'll ...
6 years, 2 months ago (2014-10-02 22:25:05 UTC) #3
Ken Russell (switch to Gerrit)
TBR'ing to piman and CQ'ing.
6 years, 2 months ago (2014-10-02 22:25:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615063004/1
6 years, 2 months ago (2014-10-02 22:27:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as aa7b1548b2ab94c282d4aa41277d11143b82e3b3
6 years, 2 months ago (2014-10-02 22:34:31 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 22:35:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66e31a6c026cd22fa2341d924f5ceb18652ec217
Cr-Commit-Position: refs/heads/master@{#297929}

Powered by Google App Engine
This is Rietveld 408576698