mojo/public/tools/bindings/generators/mojom_cpp_generator.py - Issue 615063003: Mojo cpp bindings: support Clone() for structs and arrays which don't contain handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

Issue 615063003: Mojo cpp bindings: support Clone() for structs and arrays which don't contain handles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl ('K') | « mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl ('k') | mojo/public/tools/bindings/pylib/mojom/generate/module.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

index e5f5e9de9dff0059181dedfbf5699552aa2461e0..68e0379487693e91f3c2d3aa68914081915db732 100644

--- a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

@@ -289,6 +289,7 @@ class Generator(generator.Generator):

"has_callbacks": mojom.HasCallbacks,

"should_inline": ShouldInlineStruct,

"is_any_array_kind": mojom.IsAnyArrayKind,

+ "is_cloneable_kind": mojom.IsCloneableKind,

"is_enum_kind": mojom.IsEnumKind,

"is_move_only_kind": mojom.IsMoveOnlyKind,

"is_any_handle_kind": mojom.IsAnyHandleKind,

@@ -297,6 +298,7 @@ class Generator(generator.Generator):

"is_nullable_kind": mojom.IsNullableKind,

"is_object_kind": mojom.IsObjectKind,

"is_string_kind": mojom.IsStringKind,

+ "is_struct_kind": mojom.IsStructKind,

"is_struct_with_handles": IsStructWithHandles,

"struct_size": lambda ps: ps.GetTotalSize() + _HEADER_SIZE,

"struct_from_method": generator.GetStructFromMethod,