Issue 615043002: Desugar 'super(..)' into 'super.constructor(...)'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 615043002: Desugar 'super(..)' into 'super.constructor(...)' (Closed)

Created:
6 years, 2 months ago by Dmitry Lomov (no reviews)

Modified:
6 years, 2 months ago

Reviewers:
arv (Not doing code reviews), marja

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -1 line)			Patch
	M	src/ast.h	View		1 chunk	+10 lines, -1 line	0 comments	Download
	M	test/mjsunit/harmony/super.js	View		1 chunk	+58 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

marja

Code-wise lgtm, but I haven't been following ES6 classes impl overall, so somebody else should ...

6 years, 2 months ago (2014-09-30 16:03:09 UTC) #2

arv (Not doing code reviews)

LGTM It is unclear if we want to support free standing super( outside a syntactic ...

6 years, 2 months ago (2014-09-30 16:04:55 UTC) #3

Dmitry Lomov (no reviews)

6 years, 2 months ago (2014-09-30 18:12:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24340 (presubmit successful).