Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2095)

Side by Side Diff: content/public/browser/content_browser_client.h

Issue 61503003: Additional window features are not passed as a parameter to new popup windows (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Applied changes on latest trunk. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
6 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 6 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 444 matching lines...) Expand 10 before | Expand all | Expand 10 after
455 // the window that is created should be scriptable/in the same process. 455 // the window that is created should be scriptable/in the same process.
456 // This is called on the IO thread. 456 // This is called on the IO thread.
457 virtual bool CanCreateWindow(const GURL& opener_url, 457 virtual bool CanCreateWindow(const GURL& opener_url,
458 const GURL& opener_top_level_frame_url, 458 const GURL& opener_top_level_frame_url,
459 const GURL& source_origin, 459 const GURL& source_origin,
460 WindowContainerType container_type, 460 WindowContainerType container_type,
461 const GURL& target_url, 461 const GURL& target_url,
462 const content::Referrer& referrer, 462 const content::Referrer& referrer,
463 WindowOpenDisposition disposition, 463 WindowOpenDisposition disposition,
464 const blink::WebWindowFeatures& features, 464 const blink::WebWindowFeatures& features,
465 const std::vector<string16>& additional_features,
jam 2013/11/11 17:07:18 we should keep the implementation details of no-We
465 bool user_gesture, 466 bool user_gesture,
466 bool opener_suppressed, 467 bool opener_suppressed,
467 content::ResourceContext* context, 468 content::ResourceContext* context,
468 int render_process_id, 469 int render_process_id,
469 bool is_guest, 470 bool is_guest,
470 int opener_id, 471 int opener_id,
471 bool* no_javascript_access); 472 bool* no_javascript_access);
472 473
473 // Returns a title string to use in the task manager for a process host with 474 // Returns a title string to use in the task manager for a process host with
474 // the given URL, or the empty string to fall back to the default logic. 475 // the given URL, or the empty string to fall back to the default logic.
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
602 // Returns true if plugin referred to by the url can use 603 // Returns true if plugin referred to by the url can use
603 // pp::FileIO::RequestOSFileHandle. 604 // pp::FileIO::RequestOSFileHandle.
604 virtual bool IsPluginAllowedToCallRequestOSFileHandle( 605 virtual bool IsPluginAllowedToCallRequestOSFileHandle(
605 content::BrowserContext* browser_context, 606 content::BrowserContext* browser_context,
606 const GURL& url); 607 const GURL& url);
607 }; 608 };
608 609
609 } // namespace content 610 } // namespace content
610 611
611 #endif // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 612 #endif // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698