Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: chrome/browser/chrome_content_browser_client.cc

Issue 61503003: Additional window features are not passed as a parameter to new popup windows (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Applied changes on latest trunk. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chrome_content_browser_client.h" 5 #include "chrome/browser/chrome_content_browser_client.h"
6 6
7 #include <set> 7 #include <set>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 2006 matching lines...) Expand 10 before | Expand all | Expand 10 after
2017 2017
2018 bool ChromeContentBrowserClient::CanCreateWindow( 2018 bool ChromeContentBrowserClient::CanCreateWindow(
2019 const GURL& opener_url, 2019 const GURL& opener_url,
2020 const GURL& opener_top_level_frame_url, 2020 const GURL& opener_top_level_frame_url,
2021 const GURL& source_origin, 2021 const GURL& source_origin,
2022 WindowContainerType container_type, 2022 WindowContainerType container_type,
2023 const GURL& target_url, 2023 const GURL& target_url,
2024 const content::Referrer& referrer, 2024 const content::Referrer& referrer,
2025 WindowOpenDisposition disposition, 2025 WindowOpenDisposition disposition,
2026 const WebWindowFeatures& features, 2026 const WebWindowFeatures& features,
2027 const std::vector<string16>& additional_features,
2027 bool user_gesture, 2028 bool user_gesture,
2028 bool opener_suppressed, 2029 bool opener_suppressed,
2029 content::ResourceContext* context, 2030 content::ResourceContext* context,
2030 int render_process_id, 2031 int render_process_id,
2031 bool is_guest, 2032 bool is_guest,
2032 int opener_id, 2033 int opener_id,
2033 bool* no_javascript_access) { 2034 bool* no_javascript_access) {
2034 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); 2035 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
2035 2036
2036 *no_javascript_access = false; 2037 *no_javascript_access = false;
(...skipping 589 matching lines...) Expand 10 before | Expand all | Expand 10 after
2626 return IsExtensionOrSharedModuleWhitelisted(url, extension_set, 2627 return IsExtensionOrSharedModuleWhitelisted(url, extension_set,
2627 allowed_file_handle_origins_) || 2628 allowed_file_handle_origins_) ||
2628 IsHostAllowedByCommandLine(url, extension_set, 2629 IsHostAllowedByCommandLine(url, extension_set,
2629 switches::kAllowNaClFileHandleAPI); 2630 switches::kAllowNaClFileHandleAPI);
2630 #else 2631 #else
2631 return false; 2632 return false;
2632 #endif 2633 #endif
2633 } 2634 }
2634 2635
2635 } // namespace chrome 2636 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698