Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: content/common/view_messages.h

Issue 61503003: Additional window features are not passed as a parameter to new popup windows (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Incorporated suggestions Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // IPC messages for page rendering. 5 // IPC messages for page rendering.
6 // Multiply-included message file, hence no include guard. 6 // Multiply-included message file, hence no include guard.
7 7
8 #include "base/memory/shared_memory.h" 8 #include "base/memory/shared_memory.h"
9 #include "base/process/process.h" 9 #include "base/process/process.h"
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
356 // The URL that will be loaded in the new window (empty if none has been 356 // The URL that will be loaded in the new window (empty if none has been
357 // sepcified). 357 // sepcified).
358 IPC_STRUCT_MEMBER(GURL, target_url) 358 IPC_STRUCT_MEMBER(GURL, target_url)
359 359
360 // The referrer that will be used to load |target_url| (empty if none has 360 // The referrer that will be used to load |target_url| (empty if none has
361 // been specified). 361 // been specified).
362 IPC_STRUCT_MEMBER(content::Referrer, referrer) 362 IPC_STRUCT_MEMBER(content::Referrer, referrer)
363 363
364 // The window features to use for the new view. 364 // The window features to use for the new view.
365 IPC_STRUCT_MEMBER(blink::WebWindowFeatures, features) 365 IPC_STRUCT_MEMBER(blink::WebWindowFeatures, features)
366
367 // The additional window features to use for the new view. We pass it
Tom Sepez 2013/11/11 23:07:59 nit: "we pass these" since features is plural.
368 // separately from 'features' above because we cannot serialize WebStrings
Tom Sepez 2013/11/11 23:07:59 nit: |features|, per chromium standard for delimit
369 // over IPC.
370 IPC_STRUCT_MEMBER(std::vector<string16>, additional_features)
366 IPC_STRUCT_END() 371 IPC_STRUCT_END()
367 372
368 IPC_STRUCT_BEGIN(ViewHostMsg_CreateWorker_Params) 373 IPC_STRUCT_BEGIN(ViewHostMsg_CreateWorker_Params)
369 // URL for the worker script. 374 // URL for the worker script.
370 IPC_STRUCT_MEMBER(GURL, url) 375 IPC_STRUCT_MEMBER(GURL, url)
371 376
372 // Name for a SharedWorker, otherwise empty string. 377 // Name for a SharedWorker, otherwise empty string.
373 IPC_STRUCT_MEMBER(string16, name) 378 IPC_STRUCT_MEMBER(string16, name)
374 379
375 // The ID of the parent document (unique within parent renderer). 380 // The ID of the parent document (unique within parent renderer).
(...skipping 2003 matching lines...) Expand 10 before | Expand all | Expand 10 after
2379 // synchronously (see crbug.com/120597). This IPC message sends the character 2384 // synchronously (see crbug.com/120597). This IPC message sends the character
2380 // bounds after every composition change to always have correct bound info. 2385 // bounds after every composition change to always have correct bound info.
2381 IPC_MESSAGE_ROUTED2(ViewHostMsg_ImeCompositionRangeChanged, 2386 IPC_MESSAGE_ROUTED2(ViewHostMsg_ImeCompositionRangeChanged,
2382 gfx::Range /* composition range */, 2387 gfx::Range /* composition range */,
2383 std::vector<gfx::Rect> /* character bounds */) 2388 std::vector<gfx::Rect> /* character bounds */)
2384 #endif 2389 #endif
2385 2390
2386 // Adding a new message? Stick to the sort order above: first platform 2391 // Adding a new message? Stick to the sort order above: first platform
2387 // independent ViewMsg, then ifdefs for platform specific ViewMsg, then platform 2392 // independent ViewMsg, then ifdefs for platform specific ViewMsg, then platform
2388 // independent ViewHostMsg, then ifdefs for platform specific ViewHostMsg. 2393 // independent ViewHostMsg, then ifdefs for platform specific ViewHostMsg.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698