Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 615023002: [Base] Use variadic template in base/bind_internal_win.h (wave 1) (Closed)

Created:
6 years, 2 months ago by tzik
Modified:
6 years, 2 months ago
Reviewers:
awong
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Base] Use variadic template in base/bind_internal_win.h Replace pump.py generated base/bind_internal_win.h with variadic template version. BUG=None Committed: https://crrev.com/a0125aec9fe7e38cb284d00af1fb465b2e805539 Cr-Commit-Position: refs/heads/master@{#298549}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -402 lines) Patch
M base/bind_internal_win.h View 2 chunks +16 lines, -321 lines 0 comments Download
D base/bind_internal_win.h.pump View 1 1 chunk +0 lines, -81 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tzik
PTL. This also doesn't need the workaround.
6 years, 2 months ago (2014-09-30 16:27:56 UTC) #2
awong
LGTM
6 years, 2 months ago (2014-10-07 18:41:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615023002/20001
6 years, 2 months ago (2014-10-07 18:43:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 15a7ca66e2dfa6f138ad4d7b2a7fa8f74b1ce4c5
6 years, 2 months ago (2014-10-07 20:04:05 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 20:04:46 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0125aec9fe7e38cb284d00af1fb465b2e805539
Cr-Commit-Position: refs/heads/master@{#298549}

Powered by Google App Engine
This is Rietveld 408576698