Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 614993002: Rename Constant to ConstantValue and ConstExp to ConstantExpression. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
index 70481949e4f0104278efdbdc9f56b54aedd80600..8d2d1580b1f89f76f1053d389331669a1c613ab0 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
@@ -1261,7 +1261,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
use(right);
push(new js.Binary(mapRelationalOperator(op, inverse), jsLeft, pop()));
} else {
- assert(NullConstant.JsNull == 'null');
+ assert(NullConstantValue.JsNull == 'null');
use(left);
js.Binary leftEqualsNull =
new js.Binary("==", pop(), new js.LiteralNull());
@@ -1803,15 +1803,15 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
}
}
- void generateConstant(Constant constant) {
+ void generateConstant(ConstantValue constant) {
if (constant.isFunction) {
- FunctionConstant function = constant;
+ FunctionConstantValue function = constant;
registry.registerStaticUse(function.element);
}
if (constant.isType) {
// If the type is a web component, we need to ensure the constructors are
// available to 'upgrade' the native object.
- TypeConstant type = constant;
+ TypeConstantValue type = constant;
Element element = type.representedType.element;
if (element != null && element.isClass) {
registry.registerTypeConstant(element);
@@ -2188,7 +2188,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
=> checkTypeOf(input, cmp, 'boolean');
void checkObject(HInstruction input, String cmp) {
- assert(NullConstant.JsNull == 'null');
+ assert(NullConstantValue.JsNull == 'null');
if (cmp == "===") {
checkTypeOf(input, '===', 'object');
js.Expression left = pop();

Powered by Google App Engine
This is Rietveld 408576698