Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart

Issue 614993002: Rename Constant to ConstantValue and ConstExp to ConstantExpression. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of ssa; 5 part of ssa;
6 6
7 /** 7 /**
8 * Replaces some instructions with specialized versions to make codegen easier. 8 * Replaces some instructions with specialized versions to make codegen easier.
9 * Caches codegen information on nodes. 9 * Caches codegen information on nodes.
10 */ 10 */
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 Selector selector = node.selector; 113 Selector selector = node.selector;
114 if (backend.isInterceptedSelector(selector) && 114 if (backend.isInterceptedSelector(selector) &&
115 !backend.isInterceptedMixinSelector(selector)) { 115 !backend.isInterceptedMixinSelector(selector)) {
116 HInstruction interceptor = node.inputs[0]; 116 HInstruction interceptor = node.inputs[0];
117 HInstruction receiverArgument = node.inputs[1]; 117 HInstruction receiverArgument = node.inputs[1];
118 118
119 if (interceptor.nonCheck() == receiverArgument.nonCheck()) { 119 if (interceptor.nonCheck() == receiverArgument.nonCheck()) {
120 // TODO(15933): Make automatically generated property extraction 120 // TODO(15933): Make automatically generated property extraction
121 // closures work with the dummy receiver optimization. 121 // closures work with the dummy receiver optimization.
122 if (!selector.isGetter) { 122 if (!selector.isGetter) {
123 Constant constant = new DummyConstant( 123 ConstantValue constant = new DummyConstantValue(
124 receiverArgument.instructionType); 124 receiverArgument.instructionType);
125 HConstant dummy = graph.addConstant(constant, compiler); 125 HConstant dummy = graph.addConstant(constant, compiler);
126 receiverArgument.usedBy.remove(node); 126 receiverArgument.usedBy.remove(node);
127 node.inputs[1] = dummy; 127 node.inputs[1] = dummy;
128 dummy.usedBy.add(node); 128 dummy.usedBy.add(node);
129 } 129 }
130 } 130 }
131 } 131 }
132 } 132 }
133 133
(...skipping 560 matching lines...) Expand 10 before | Expand all | Expand 10 after
694 } 694 }
695 695
696 // If [thenInput] is defined in the first predecessor, then it is only used 696 // If [thenInput] is defined in the first predecessor, then it is only used
697 // by [phi] and can be generated at use site. 697 // by [phi] and can be generated at use site.
698 if (identical(thenInput.block, end.predecessors[0])) { 698 if (identical(thenInput.block, end.predecessors[0])) {
699 assert(thenInput.usedBy.length == 1); 699 assert(thenInput.usedBy.length == 1);
700 markAsGenerateAtUseSite(thenInput); 700 markAsGenerateAtUseSite(thenInput);
701 } 701 }
702 } 702 }
703 } 703 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698